702591 - finalize statements in toolkit/components/satchel/test/unit/

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect)

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: finalize statements in toolkit/components/satchel/test/unit/

https://tbpl.mozilla.org/?tree=Try&rev=a3accd561888

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 574585 [details] [diff] [review]
finalize statements in toolkit/components/satchel/test/unit/

Review of attachment 574585 [details] [diff] [review]:
-----------------------------------------------------------------

Again, I don't know this code enough.

Comment 3

[Marco Bonardo [:mak]]

Comment on attachment 574585 [details] [diff] [review]
finalize statements in toolkit/components/satchel/test/unit/

Review of attachment 574585 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, if passes try it will be fine

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Comment on attachment 574585 [details] [diff] [review]
finalize statements in toolkit/components/satchel/test/unit/

I am traveling and don't have my ssh key with me. Can you check it in?

Comment 5

[Marco Bonardo [:mak]]

the tree is not in a good shape atm, so setting checkin-needed in case someone hits this before I do

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 574585 [details] [diff] [review]
finalize statements in toolkit/components/satchel/test/unit/

https://hg.mozilla.org/integration/mozilla-inbound/rev/e66da0d020e7

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e66da0d020e7