Closed Bug 702591 Opened 10 years ago Closed 10 years ago

finalize statements in toolkit/components/satchel/test/unit/

Categories

(Toolkit :: Form Manager, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: espindola, Assigned: espindola)

References

Details

Attachments

(1 file)

No description provided.
https://tbpl.mozilla.org/?tree=Try&rev=a3accd561888
Assignee: nobody → respindola
Status: NEW → ASSIGNED
Attachment #574585 - Flags: review?(mak77)
Attachment #574585 - Flags: feedback?(honzab.moz)
Comment on attachment 574585 [details] [diff] [review]
finalize statements in toolkit/components/satchel/test/unit/

Review of attachment 574585 [details] [diff] [review]:
-----------------------------------------------------------------

Again, I don't know this code enough.
Attachment #574585 - Flags: feedback?(honzab.moz)
Comment on attachment 574585 [details] [diff] [review]
finalize statements in toolkit/components/satchel/test/unit/

Review of attachment 574585 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, if passes try it will be fine
Attachment #574585 - Flags: review?(mak77) → review+
Comment on attachment 574585 [details] [diff] [review]
finalize statements in toolkit/components/satchel/test/unit/

I am traveling and don't have my ssh key with me. Can you check it in?
Attachment #574585 - Flags: checkin?
Attachment #574585 - Flags: checkin? → checkin?(mak77)
the tree is not in a good shape atm, so setting checkin-needed in case someone hits this before I do
Keywords: checkin-needed
Comment on attachment 574585 [details] [diff] [review]
finalize statements in toolkit/components/satchel/test/unit/

https://hg.mozilla.org/integration/mozilla-inbound/rev/e66da0d020e7
Attachment #574585 - Flags: checkin?(mak77) → checkin+
Keywords: checkin-needed
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/e66da0d020e7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.