Flash should use Skia to implement ANPCanvas and similar interfaces

RESOLVED FIXED

Status

()

Firefox for Android
General
P1
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: snorp, Assigned: snorp)

Tracking

unspecified
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Right now we try to implement ANPCanvas/ANPPath/ANPTypeface/ANPPaint etc. with gfxContext and friends. This is a lot of work, and we have only implemented a small fraction of the interfaces. It is pretty clear that the ANP API is designed to be a thin wrapper over Skia, so it should be trivial to take the WebKit Skia-based implementation directly. My understanding is that the gfx folks are moving to Skia anyway (it's already in-tree).
Created attachment 574592 [details] [diff] [review]
Use Skia to implement the Android canvas plugin APIs
Attachment #574592 - Flags: review?(blassey.bugs)
Comment on attachment 574592 [details] [diff] [review]
Use Skia to implement the Android canvas plugin APIs

Review of attachment 574592 [details] [diff] [review]:
-----------------------------------------------------------------

Move the apache licenced files into other-lisenced/skia-npapi and build a static library the that you can link to in dom/plugin/base/android

With that change this its a rubber stamp
Attachment #574592 - Flags: review?(blassey.bugs) → review-
Created attachment 574623 [details] [diff] [review]
Use Skia to implement the Android canvas plugin APIs
Attachment #574623 - Flags: review?(blassey.bugs)
Attachment #574592 - Attachment is obsolete: true
Attachment #574623 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/projects/birch/rev/e84fa7cf77ad
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.