702733 - Fennec does not exit properly if fast startup view has been closed

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Widget: Qt, defect)

Description

[Oleg Romashin (:romaxa)]

While fast startup view is shown user can try to close fennec,
current code emits single XUL_CLOSE event, but that fail, because it is not started yet, so as result we have partially started xul, no window, and not possible to start fennec again...

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Exit quickly if window close before XUL/layout initialized (while screenshot is shown)

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 574657 [details] [diff] [review]
Exit quickly if window close before XUL/layout initialized (while screenshot is shown)

Review of attachment 574657 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/src/qt/faststartupqt/nsFastStartupQt.cpp
@@ +117,5 @@
>    sFastStartup = 0;
>  }
>  
>  void
> +nsFastStartup::CloseRequested()

can't this just call RemoveFakeLayout, then exit()?

Comment 3

[Oleg Romashin (:romaxa)]

Then I see some warnings in terminal, which complain about not freed resources... but not sure if we really care about it before exit...

Comment 4

[Oleg Romashin (:romaxa)]

Attachment: Exit quickly if window close before XUL/layout initialized (while screenshot is shown)

updated version

Comment 5

[Benjamin Smedberg]

In bug 1282866, I have removed the QT code from the Firefox tree with the approval of the active peer. That code is not currently maintained by any team.

I have looked through the bugs in the Widget: Qt bugzilla component and I believe all of these are no longer relevant because the Qt code has been removed. If you believe that this bug is still valid, please move it to another more appropriate bugzilla component as you reopen it.