Closed Bug 702753 Opened 12 years ago Closed 12 years ago

implement "make install" for android

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: blassey, Assigned: blassey)

References

Details

Attachments

(1 file)

patch
758 bytes, patch
dougt
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
wasted time today because we bumped the version number, this will hopefully avoid that in the future
Attachment #574675 - Flags: review?(doug.turner)
Comment on attachment 574675 [details] [diff] [review]
patch

This is kinda brittle, since it assumes adb and a single device. I mean it's not that useful in a general sense. Should it be in the tree?
Blocks: 702486
(In reply to Mark Finkle (:mfinkle) from comment #1)
> Comment on attachment 574675 [details] [diff] [review] [diff] [details] [review]
> patch
> 
> This is kinda brittle, since it assumes adb and a single device. I mean it's
> not that useful in a general sense. Should it be in the tree?

using device manager may be better impl, but I figure this is the base case. Happy to file a follow up bug to do better.
Attachment #574675 - Flags: review?(doug.turner) → review+
Assignee: nobody → blassey.bugs
Why does this block bug 702829 ?
I assume because Naoki created bug 702829 as a clone of bug 702486
No longer blocks: 702829
Brad landed https://hg.mozilla.org/projects/birch/rev/bcada4117c30

Ifixed some bustage https://hg.mozilla.org/projects/birch/rev/452d17984010
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.