The default bug view has changed. See this FAQ.

Library loading times need to be adjusted on birch

RESOLVED FIXED in mozilla11

Status

()

Core
Widget: Android
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: (dormant account), Assigned: glandium)

Tracking

Trunk
mozilla11
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
We should use RUSAGE_THREAD in getrusage. This will allow us to capture cpu time spent on library loading and compare it to overall cpu time.
(Reporter)

Updated

5 years ago
Assignee: nobody → mh+mozilla
(Assignee)

Comment 1

5 years ago
Why birch only?
(Reporter)

Comment 2

5 years ago
(In reply to Mike Hommey [:glandium] from comment #1)
> Why birch only?

birch is my justification. This should happen on mc too.
(Reporter)

Comment 3

5 years ago
Note we also need another metric to see how long the process was alive before we started loading libraries, this will notify us of lag introduced by native ui.
(Assignee)

Updated

5 years ago
OS: Windows 7 → Android
Hardware: x86 → ARM

Comment 4

5 years ago
put it on m-c.  we can merge it in.
(Assignee)

Comment 5

5 years ago
Created attachment 574921 [details] [diff] [review]
part 1 - Use RUSAGE_THREAD for library loading time consumption reporting
Attachment #574921 - Flags: review?(tglek)
(Reporter)

Updated

5 years ago
Attachment #574921 - Flags: review?(tglek) → review+
(Assignee)

Comment 6

5 years ago
Created attachment 575222 [details] [diff] [review]
part 2 - Make nsAppStartup::GetStartupInfo more flexible
Attachment #575222 - Flags: review?(tglek)
(Assignee)

Comment 7

5 years ago
Created attachment 575225 [details] [diff] [review]
part 3 - Add linker initialization and library loading timestamps for nsAppStartup::GetStartupInfo

Pushed to try:
https://tbpl.mozilla.org/?noignore=1&tree=Try&rev=d21392a69d35
Attachment #575225 - Flags: review?(tglek)
(Assignee)

Comment 8

5 years ago
Another try that doesn't fail due to the switch to mobile/xul tree:
https://tbpl.mozilla.org/?noignore=1&tree=Try&rev=09e355059af0
(Reporter)

Updated

5 years ago
Attachment #575225 - Flags: review?(tglek) → review+
(Reporter)

Comment 9

5 years ago
Comment on attachment 575222 [details] [diff] [review]
part 2 - Make nsAppStartup::GetStartupInfo more flexible

RecordOnce is more expensive, but I understand why you do it
Attachment #575222 - Flags: review?(tglek) → review+
(Assignee)

Comment 10

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/80ddfdb7e575
http://hg.mozilla.org/integration/mozilla-inbound/rev/f9f4594a621b
http://hg.mozilla.org/integration/mozilla-inbound/rev/c744ccd70348
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/80ddfdb7e575
https://hg.mozilla.org/mozilla-central/rev/f9f4594a621b
https://hg.mozilla.org/mozilla-central/rev/c744ccd70348
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.