Missing margin in the highlighter and web console buttons

RESOLVED FIXED in Firefox 11

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sonny, Assigned: sonny)

Tracking

Trunk
Firefox 11
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

6 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20100101 Firefox/8.0
Build ID: 20111106170155
(Assignee)

Updated

6 years ago
Hardware: x86_64 → All

Comment 1

6 years ago
Created attachment 574847 [details]
highlighter buttons

Comment 2

6 years ago
Created attachment 574848 [details]
console buttons

Updated

6 years ago
Assignee: nobody → sonny.piers
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 3

6 years ago
Created attachment 574888 [details] [diff] [review]
patch v1

This makes all toolbarbuttons on linux 3px margins on left/right.
Attachment #574888 - Flags: review?(mihai.sucan)
(Assignee)

Comment 4

6 years ago
(on devtools)

Comment 5

6 years ago
Usually, on Linux, toolbar-buttons don't need margins. The separation is done with the padding. But it doesn't look good if the buttons have borders (like the highlighter and the web console).

That's why we need this patch.
Comment on attachment 574888 [details] [diff] [review]
patch v1

Review of attachment 574888 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good! Thank you very much for your contribution Sonny! r+!
Attachment #574888 - Flags: review?(mihai.sucan) → review+
(Assignee)

Updated

6 years ago
Attachment #574888 - Flags: review?(dao)

Updated

6 years ago
Attachment #574888 - Flags: review?(dao) → review+

Updated

6 years ago
Whiteboard: [land-in-fx-team]

Comment 7

6 years ago
This doesn't pass all the tests:

INFO | runtests.py | Running tests: end.
mochitest-browser-chrome failed:
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/highlighter/test/browser_inspector_highlighter.js | transparent veil box width matches dimensions of element (no zoom) - Got 0, expected 22
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/highlighter/test/browser_inspector_highlighter.js | transparent veil box height matches dimensions of element (no zoom) - Got 0, expected 22
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/highlighter/test/browser_inspector_highlighter.js | transparent veil box width matches width of element (2x zoom) - Got 947, expected 44
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/highlighter/test/browser_inspector_highlighter.js | transparent veil box height matches width of element (2x zoom) - Got 154, expected 44
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/highlighter/test/browser_inspector_iframeTest.js | selection matches div2 node - Got [object HTMLDivElement], expected [object HTMLDivElement]
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/highlighter/test/browser_inspector_iframeTest.js | highlighter matches selection - Got [object HTMLDivElement], expected [object HTMLDivElement]

This is interesting because we have the same problem with bug 700333

Updated

6 years ago
Whiteboard: [land-in-fx-team]

Updated

6 years ago
Depends on: 703237

Updated

6 years ago
No longer depends on: 703237

Updated

6 years ago
Whiteboard: [land-in-fxteam]
Whiteboard: [land-in-fxteam] → [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/9f68a7bd5abe

in fx-team. Thanks for the patch, sonny!
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/9f68a7bd5abe
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 11
You need to log in before you can comment on or make changes to this bug.