702776 - Missing margin in the highlighter and web console buttons

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Sonny Piers [:sonny]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20100101 Firefox/8.0
Build ID: 20111106170155

Comment 1

[Paul Rouget [:paul]]

Attachment: highlighter buttons

Comment 2

[Paul Rouget [:paul]]

Attachment: console buttons

Comment 3

[Sonny Piers [:sonny]]

Attachment: patch v1

This makes all toolbarbuttons on linux 3px margins on left/right.

Comment 4

[Sonny Piers [:sonny]]

(on devtools)

Comment 5

[Paul Rouget [:paul]]

Usually, on Linux, toolbar-buttons don't need margins. The separation is done with the padding. But it doesn't look good if the buttons have borders (like the highlighter and the web console).

That's why we need this patch.

Comment 6

[Mihai Sucan [:msucan]]

Comment on attachment 574888 [details] [diff] [review]
patch v1

Review of attachment 574888 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good! Thank you very much for your contribution Sonny! r+!

Comment 7

[Paul Rouget [:paul]]

This doesn't pass all the tests:

INFO | runtests.py | Running tests: end.
mochitest-browser-chrome failed:
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/highlighter/test/browser_inspector_highlighter.js | transparent veil box width matches dimensions of element (no zoom) - Got 0, expected 22
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/highlighter/test/browser_inspector_highlighter.js | transparent veil box height matches dimensions of element (no zoom) - Got 0, expected 22
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/highlighter/test/browser_inspector_highlighter.js | transparent veil box width matches width of element (2x zoom) - Got 947, expected 44
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/highlighter/test/browser_inspector_highlighter.js | transparent veil box height matches width of element (2x zoom) - Got 154, expected 44
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/highlighter/test/browser_inspector_iframeTest.js | selection matches div2 node - Got [object HTMLDivElement], expected [object HTMLDivElement]
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/highlighter/test/browser_inspector_iframeTest.js | highlighter matches selection - Got [object HTMLDivElement], expected [object HTMLDivElement]

This is interesting because we have the same problem with bug 700333

Comment 8

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/9f68a7bd5abe

in fx-team. Thanks for the patch, sonny!

Comment 9

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/mozilla-central/rev/9f68a7bd5abe