702801 - [traceback] AttributeError: 'NoneType' object has no attribute 'id'

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://apps-preview-dev.allizom.org/en-US/developers/app/app-6/submit/3


actual behavior:
  File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/amo/decorators.py", line 102, in wrapper
    return f(*args, **kw)

  File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/amo/decorators.py", line 94, in wrapper
    return f(*args, **kw)

  File "/usr/lib64/python2.6/contextlib.py", line 34, in __exit__
    self.gen.throw(type, value, traceback)

  File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/amo/models.py", line 38, in skip_cache
    yield

  File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/amo/decorators.py", line 94, in wrapper
    return f(*args, **kw)

  File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/devhub/decorators.py", line 58, in wrapper
    return f(request, *args, webapp=show_webapp, **kwargs)

  File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/addons/decorators.py", line 30, in wrapper
    return f(request, addon, *args, **kw)

  File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/amo/decorators.py", line 28, in wrapper
    return func(request, *args, **kw)

  File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/devhub/decorators.py", line 40, in wrapper
    return fun()

  File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/devhub/decorators.py", line 24, in <lambda>
    **kw)

  File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/devhub/views.py", line 1272, in wrapper
    return f(request, *args, **kw)

  File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/devhub/views.py", line 1413, in submit_describe
    request=request)

  File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/addons/forms.py", line 294, in __init__
    self.addon.is_featured(app))

  File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/addons/models.py", line 824, in is_featured
    return self.id in FeaturedManager.featured_ids(app, lang)

  File "/data/www/apps-preview-dev.allizom.org/zamboni/lib/lru_cache.py", line 52, in wrapper
    result = user_function(*args, **kwds)

  File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/amo/utils.py", line 526, in wrapper
    data = func(*args, **kwargs)

  File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/addons/utils.py", line 176, in featured_ids
    base = (cls.by_id, cls.by_app(app.id))
AttributeError: 'NoneType' object has no attribute 'id'

app uploaded: https://people.mozilla.com/~kraj/test-files/webapps/mozilla-ball.webapp

http://arecibo1.dmz.phx1.mozilla.com/view/51727/

Comment 1

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/ffd16d9

Comment 2

[krupa raj[:krupa]]

App submission works now: https://apps-preview-dev.allizom.org/en-US/developers/app/app-6/submit/5