Closed Bug 702821 Opened 8 years ago Closed 8 years ago

Doorhanger arrow should point favicon

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED

People

(Reporter: sriram, Assigned: sriram)

Details

Attachments

(2 files)

With the new design in 701370, the doorhanger should point to favicon.
Attached patch WIPSplinter Review
This patch moves the arrow to point to favicon.
Also, this patch clears some visual glitch (of around 1dp) on each side of the doorhangers. Now the doorhangers bleed to the edge (well, almost :( ).
However, the arrow is pixellated in this. We need higher fidelity images for hdpi and xhdpi.
Assignee: nobody → sriram
Attachment #574720 - Flags: review?(mark.finkle)
Comment on attachment 574720 [details] [diff] [review]
WIP

Could we file a bug to use the dropdown anchor (the favicon) as the way to set the doorhanger arrow margin? It would be less brittle.
Attachment #574720 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/projects/birch/rev/0c811a2f564d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.