702868 - AddonInternal.hasBinaryComponents doesn't affect AddonInternal.appDisabled until after initial install

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Addons with binary components that aren't strictly compatible are still able to get installed.

Cause: loadManifestFromRDF() sets appDisabled based on isUsableAddon(). However, hasBinaryComponents isn't determined until after loadManifestFromRDF() returns, so it's not taken into account until after the addon is installed.



(Thanks to Virgil in QA for catching this.)

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/integration/fx-team/rev/6b2a7c8e58de

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 574855 [details] [diff] [review]
Patch v1

Same deal as bug 700201 - part of the big compatible-by-default push, which isn't enabled on Aurora yet (though it will soon be on central!), but would like to get this in so QA can go over it and to avoid bitrot.

Comment 4

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 574855 [details] [diff] [review]
Patch v1

Please land on M-C (currently on fx-team) as well as Aurora.

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/mozilla-central/rev/6b2a7c8e58de

Comment 6

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b621aa998435

Comment 7

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (Windows NT 5.1; rv:11.0a1) Gecko/20111127 Firefox/11.0a1
Mozilla/5.0 (Windows NT 5.1; rv:10.0a2) Gecko/20111127 Firefox/10.0a2

https://addons.mozilla.org/en-US/firefox/addon/foxytunes/?src=ss
https://addons.mozilla.org/en-US/firefox/addon/grafx-bot/?src=ss

Verified Aurora and Nightly on Ubuntu 11.10, Windows XP, 7, Mac OS 10.6.

Binary add-ons can no longer be installed with strictCompatibility enabled.