Closed
Bug 702868
Opened 9 years ago
Closed 9 years ago
AddonInternal.hasBinaryComponents doesn't affect AddonInternal.appDisabled until after initial install
Categories
(Toolkit :: Add-ons Manager, defect, P1)
Tracking
()
VERIFIED
FIXED
mozilla11
Tracking | Status | |
---|---|---|
firefox10 | --- | fixed |
People
(Reporter: Unfocused, Assigned: Unfocused)
References
Details
(Keywords: verified-aurora, Whiteboard: [qa!])
Attachments
(1 file)
6.76 KB,
patch
|
mossop
:
review+
lmandel
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Addons with binary components that aren't strictly compatible are still able to get installed. Cause: loadManifestFromRDF() sets appDisabled based on isUsableAddon(). However, hasBinaryComponents isn't determined until after loadManifestFromRDF() returns, so it's not taken into account until after the addon is installed. (Thanks to Virgil in QA for catching this.)
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #574855 -
Flags: review?(dtownsend)
Updated•9 years ago
|
Attachment #574855 -
Flags: review?(dtownsend) → review+
Assignee | ||
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/6b2a7c8e58de
Flags: in-testsuite+
Flags: in-litmus-
Target Milestone: --- → mozilla11
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 574855 [details] [diff] [review] Patch v1 Same deal as bug 700201 - part of the big compatible-by-default push, which isn't enabled on Aurora yet (though it will soon be on central!), but would like to get this in so QA can go over it and to avoid bitrot.
Attachment #574855 -
Flags: approval-mozilla-aurora?
Comment 4•9 years ago
|
||
Comment on attachment 574855 [details] [diff] [review] Patch v1 Please land on M-C (currently on fx-team) as well as Aurora.
Attachment #574855 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6b2a7c8e58de
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/b621aa998435
Assignee | ||
Updated•9 years ago
|
Comment 7•9 years ago
|
||
Mozilla/5.0 (Windows NT 5.1; rv:11.0a1) Gecko/20111127 Firefox/11.0a1 Mozilla/5.0 (Windows NT 5.1; rv:10.0a2) Gecko/20111127 Firefox/10.0a2 https://addons.mozilla.org/en-US/firefox/addon/foxytunes/?src=ss https://addons.mozilla.org/en-US/firefox/addon/grafx-bot/?src=ss Verified Aurora and Nightly on Ubuntu 11.10, Windows XP, 7, Mac OS 10.6. Binary add-ons can no longer be installed with strictCompatibility enabled.
You need to log in
before you can comment on or make changes to this bug.
Description
•