The document of nsIImportAddressBooks::GetSampleData is ambiguous

RESOLVED FIXED in Thunderbird 11.0

Status

MailNews Core
Import
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: hiro, Assigned: hiro)

Tracking

Trunk
Thunderbird 11.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
I actually misunderstood that the recordNumber of GetSampleData starts from 1.
(Assignee)

Comment 1

6 years ago
Created attachment 574791 [details] [diff] [review]
Additional info for params
Attachment #574791 - Flags: review?(dbienvenu)

Comment 2

6 years ago
Comment on attachment 574791 [details] [diff] [review]
Additional info for params

thx for the patch - can you remove the space after the '(' in the method line?

You should probably also add an @returns line after the param to tell what the method returns, e.g.,

@returns a string of sample data for the desired record
Attachment #574791 - Flags: review?(dbienvenu) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 576644 [details] [diff] [review]
Revised patch

Addressing review comments.

Carrying over review+.
Assignee: nobody → hiikezoe
Attachment #574791 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #576644 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/52091c6aa7f9
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0
You need to log in before you can comment on or make changes to this bug.