Last Comment Bug 702881 - The document of nsIImportAddressBooks::GetSampleData is ambiguous
: The document of nsIImportAddressBooks::GetSampleData is ambiguous
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Import (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 11.0
Assigned To: Hiroyuki Ikezoe (:hiro)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-15 21:56 PST by Hiroyuki Ikezoe (:hiro)
Modified: 2011-11-24 23:18 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Additional info for params (1.46 KB, patch)
2011-11-15 21:57 PST, Hiroyuki Ikezoe (:hiro)
mozilla: review+
Details | Diff | Splinter Review
Revised patch (1.60 KB, patch)
2011-11-23 16:05 PST, Hiroyuki Ikezoe (:hiro)
hiikezoe: review+
Details | Diff | Splinter Review

Description Hiroyuki Ikezoe (:hiro) 2011-11-15 21:56:23 PST
I actually misunderstood that the recordNumber of GetSampleData starts from 1.
Comment 1 Hiroyuki Ikezoe (:hiro) 2011-11-15 21:57:43 PST
Created attachment 574791 [details] [diff] [review]
Additional info for params
Comment 2 David :Bienvenu 2011-11-17 13:46:31 PST
Comment on attachment 574791 [details] [diff] [review]
Additional info for params

thx for the patch - can you remove the space after the '(' in the method line?

You should probably also add an @returns line after the param to tell what the method returns, e.g.,

@returns a string of sample data for the desired record
Comment 3 Hiroyuki Ikezoe (:hiro) 2011-11-23 16:05:27 PST
Created attachment 576644 [details] [diff] [review]
Revised patch

Addressing review comments.

Carrying over review+.
Comment 4 Makoto Kato [:m_kato] 2011-11-24 23:18:30 PST
http://hg.mozilla.org/comm-central/rev/52091c6aa7f9

Note You need to log in before you can comment on or make changes to this bug.