The default bug view has changed. See this FAQ.

IAccessibleRelation::get_target broken

RESOLVED FIXED in Firefox 9

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

({access, regression})

unspecified
mozilla11
All
Windows 7
access, regression
Points:
---

Firefox Tracking Flags

(firefox9 fixed, firefox10 fixed)

Details

(Whiteboard: [qa?])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 574843 [details] [diff] [review]
patch

regression from bug 641838
Attachment #574843 - Flags: review?(trev.saunders)
(Assignee)

Updated

5 years ago
Assignee: nobody → surkov.alexander
(Assignee)

Updated

5 years ago
Summary: IAccessibleRelation::get_relation broken → IAccessibleRelation::get_target broken
Attachment #574843 - Flags: review?(trev.saunders) → review+
(Assignee)

Comment 1

5 years ago
inbound land https://hg.mozilla.org/integration/mozilla-inbound/rev/190255a17276
https://hg.mozilla.org/mozilla-central/rev/190255a17276
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
(Assignee)

Comment 3

5 years ago
Comment on attachment 574843 [details] [diff] [review]
patch

broken implementation of major accessibility API what prevents screen readers and other ATs to rely on it. Trivial patch, safe to take.
Attachment #574843 - Flags: approval-mozilla-beta?
Attachment #574843 - Flags: approval-mozilla-aurora?

Comment 4

5 years ago
Comment on attachment 574843 [details] [diff] [review]
patch

[triage comment]
Approved for aurora and beta. Please land today if at possible.
Attachment #574843 - Flags: approval-mozilla-beta?
Attachment #574843 - Flags: approval-mozilla-beta+
Attachment #574843 - Flags: approval-mozilla-aurora?
Attachment #574843 - Flags: approval-mozilla-aurora+

Comment 5

5 years ago
Errr, so I tried to transplant this and it already looks to be on beta and aurora...am I missing something? (entirely possible)

Comment 6

5 years ago
Ah, and I was missing that someone landed it under me :-)

http://hg.mozilla.org/releases/mozilla-aurora/rev/e47a1f1fdfbd
http://hg.mozilla.org/releases/mozilla-beta/rev/a8b9b7d98fb5
status-firefox10: --- → fixed
status-firefox9: --- → fixed
Yeah sorry about that. There's an expectation that we comment all landings but we sometimes forget.
(Assignee)

Comment 8

5 years ago
Thank you for landing.

Christian, any chance we can deliver this patch as update to released Firefox 8? What's conditions?

Comment 9

5 years ago
You need to show impact (pref. with numbers) and also show why this wasn't caught during Nightly, Aurora, or Beta if the impact is large. The bar is very, very high, especially as we are 1/2 way through the cycle towards Fx9.

Basically, we need to trade off the pain/annoyance/egg-on-our-face of a 8.0.2 with waiting a couple more weeks for the fix. Note that this calculation will change somewhat when we have less disruptive updates.
(Assignee)

Comment 10

5 years ago
Ok, I see. No known major affected ATs, that's why it was noticed when Firefox 8 was released. This is egg-on-our-face problem but due to fast release cycle impact might be not large.
Is there something QA can do to verify this fix?
Whiteboard: [qa?]
Quickest route to verifying this is using DOM Inspector, which I'm trying to download to test with FF9 but the download is failing. Will update when I get somewhere.
OK got it. Verified relations are exposed in FF9. Verification via DOM Inspector "Accessible Tree" view and "Accessible Relations" object view.
And also confirmed properly with accprobe, the IA2 relations are exposed.
You need to log in before you can comment on or make changes to this bug.