702903 - IAccessibleRelation::get_target broken

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

regression from bug 641838

Comment 1

[alexander :surkov (:asurkov)]

inbound land https://hg.mozilla.org/integration/mozilla-inbound/rev/190255a17276

Comment 2

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/190255a17276

Comment 3

[alexander :surkov (:asurkov)]

Comment on attachment 574843 [details] [diff] [review]
patch

broken implementation of major accessibility API what prevents screen readers and other ATs to rely on it. Trivial patch, safe to take.

Comment 4

[LegNeato]

Comment on attachment 574843 [details] [diff] [review]
patch

[triage comment]
Approved for aurora and beta. Please land today if at possible.

Comment 5

[LegNeato]

Errr, so I tried to transplant this and it already looks to be on beta and aurora...am I missing something? (entirely possible)

Comment 6

[LegNeato]

Ah, and I was missing that someone landed it under me :-)

http://hg.mozilla.org/releases/mozilla-aurora/rev/e47a1f1fdfbd
http://hg.mozilla.org/releases/mozilla-beta/rev/a8b9b7d98fb5

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

Yeah sorry about that. There's an expectation that we comment all landings but we sometimes forget.

Comment 8

[alexander :surkov (:asurkov)]

Thank you for landing.

Christian, any chance we can deliver this patch as update to released Firefox 8? What's conditions?

Comment 9

[LegNeato]

You need to show impact (pref. with numbers) and also show why this wasn't caught during Nightly, Aurora, or Beta if the impact is large. The bar is very, very high, especially as we are 1/2 way through the cycle towards Fx9.

Basically, we need to trade off the pain/annoyance/egg-on-our-face of a 8.0.2 with waiting a couple more weeks for the fix. Note that this calculation will change somewhat when we have less disruptive updates.

Comment 10

[alexander :surkov (:asurkov)]

Ok, I see. No known major affected ATs, that's why it was noticed when Firefox 8 was released. This is egg-on-our-face problem but due to fast release cycle impact might be not large.

Comment 11

[u279076]

Is there something QA can do to verify this fix?

Comment 12

[David Bolter [:davidb] (NeedInfo me for attention)]

Quickest route to verifying this is using DOM Inspector, which I'm trying to download to test with FF9 but the download is failing. Will update when I get somewhere.

Comment 13

[David Bolter [:davidb] (NeedInfo me for attention)]

OK got it. Verified relations are exposed in FF9. Verification via DOM Inspector "Accessible Tree" view and "Accessible Relations" object view.

Comment 14

[David Bolter [:davidb] (NeedInfo me for attention)]

And also confirmed properly with accprobe, the IA2 relations are exposed.