702958 - mozhttpd seems to have a problem with %252F -> %2f

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in tp5, there is a link to:
http://localhost/page_load_test/tp5/linkedin.com/www.linkedin.com/in/christopherblizzard@goback=.nppvan_%252Flemuelf.html

in literal translation with mozhttpd, we translate this to:
/page_load_test/tp5/linkedin.com/www.linkedin.com/in/christopherblizzard@goback=.nppvan_%252Flemuelf.html

on the file system, we have this file:
page_load_test/tp5/linkedin.com/www.linkedin.com/in/christopherblizzard@goback=.nppvan_%2Flemuelf.html


So when using apache we translate %252F -> %2F on the file system and %2f doesn't work.  Mozhttpd should support this mode.

Comment 1

[Jeff Hammel]

In theory should just be able to url decode it.  Its becoming clearer that SimpleHTTPServer is just that

Comment 2

[Burak Yiğit Kaya [:BYK]]

Attachment: Fix for urldecoding and path splitting

Comment 3

[Burak Yiğit Kaya [:BYK]]

Attachment: Fix for urldecoding and path splitting

I forgot to remove the "print" statement used for debugging. Attaching the fixed patch, sorry.

Comment 4

[Jeff Hammel]

Comment on attachment 574925 [details] [diff] [review]
Fix for urldecoding and path splitting

Looks good!

Comment 5

[Jeff Hammel]

pushed: http://hg.mozilla.org/build/talos/rev/b76d25c978df

Thanks for the patch!