702994 - File Viewer syntax highlighting broken with single quote mark

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Andrew Williamson [:eviljeff]]

The file viewer seems to have occasional trouble handling some single quotes.  In the URL link you should be able to see the closing ' of the string ignored so the following lines in the files shown as part of a string rather than executable code.

this is the line:
[var toolbar_container = document.createElement('hbox');]

Comment 1

[Kris Maglione [:kmag]]

The syntax highlighter should give up on any strings at the end of a line unless the line ends in a backslash. I see this all the time and wind up using an external diff viewer as a result.

Comment 2

[Kris Maglione [:kmag]]

The following seems to do the trick:

    $.extend(SyntaxHighlighter.regexLib, {
        multiLineDoubleQuotedString: /"([^\\"\n]|\\[^])*"/g,
        multiLineSingleQuotedString: /'([^\\'\n]|\\[^])*'/g
    });

Comment 3

[Andrew Williamson [:eviljeff]]

https://github.com/mozilla/zamboni/commit/9700a9a

Comment 4

[Andrew Williamson [:eviljeff]]

https://addons-dev.allizom.org/en-US/firefox/files/browse/108763/file/content/alxtb2ff.js#L1280

https://addons.mozilla.org/en-US/firefox/files/browse/108763/file/content/alxtb2ff.js#L1280