703090 - Clear old places preferences

Status: RESOLVED WONTFIX

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

On some of the next schema changes we should clear some old prefs that are unused, for example:

places.history.expiration.transient_optimal_database_size
places.last_vacuum

Comment 1

[Marco Bonardo [:mak]]

also:
Browser.history_expire_sites
browser.history_expire_days.mirror
browser.history_expire_days_min

Comment 2

[David E. Ross]

Will some of those preference variables be needed if bug #660646 is implemented?

Comment 3

[Marco Bonardo [:mak]]

(In reply to David E. Ross from comment #2)
> Will some of those preference variables be needed if bug #660646 is
> implemented?

likely would get new preference names in such a case, the benefit to reuse old names is minor (and the old system was ugly).

Comment 4

[katzelad]

hi, im new.
how can i get assigned to/start working on this bug?

Comment 5

[Marco Bonardo [:mak]]

Exactly like that :)

So, the idea here is to add a Schema Migration in Database.h/cpp (http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/Database.cpp) to clear these old preferences

Comment 6

[Marco Bonardo [:mak]]

The introduction reference is at https://developer.mozilla.org/en-US/docs/Introduction if you need any info on how to get code, build prerequisites and such.
For any other question feel free to ask here, in #introduction or #fx-team on moznet

Comment 7

[Marco Bonardo [:mak]]

unassigning since we didn't hear back from the assignee recently

Comment 8

[thomasleong3]

Hi, I was taking a look at this in the Database.cpp file. Does this have a schema version number?

Also, I found some lines are are similar to removing preferences in the file. Is it something like this?
(void)Preferences::ClearUser("browser.history_expire_sites");

I found this line in the Database.cpp file.
(void)Preferences::ClearUser("browser.bookmarks.livemark_refresh_seconds");

Comment 9

[[e-mail]]

@mak any thought for comment 8?

Comment 10

[Marco Bonardo [:mak]]

(In reply to thomasleong3 from comment #8)
> Hi, I was taking a look at this in the Database.cpp file. Does this have a
> schema version number?

Yes, it's in Database.h

> Also, I found some lines are are similar to removing preferences in the
> file. Is it something like this?
> (void)Preferences::ClearUser("browser.history_expire_sites");

yes.

the fact is, on a second thought, I think this should be fixed when we actually will need to do a schema bump... It will happen sooner or later.
Doing a schema bump just for this is expensive.
So, I think I'm going to WONTFIX this, and will try to remember next time I write a schema migration to also clear some prefs...

Sorry for late reply, I hope you can find a better bug to work on, please have a look at http://www.joshmatthews.net/bugsahoy/