Closed
Bug 703090
Opened 13 years ago
Closed 8 years ago
Clear old places preferences
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: mak, Unassigned, Mentored)
Details
(Whiteboard: [good first bug][lang=cpp])
On some of the next schema changes we should clear some old prefs that are unused, for example: places.history.expiration.transient_optimal_database_size places.last_vacuum
Reporter | ||
Comment 1•13 years ago
|
||
also: Browser.history_expire_sites browser.history_expire_days.mirror browser.history_expire_days_min
Comment 2•12 years ago
|
||
Will some of those preference variables be needed if bug #660646 is implemented?
Reporter | ||
Comment 3•12 years ago
|
||
(In reply to David E. Ross from comment #2) > Will some of those preference variables be needed if bug #660646 is > implemented? likely would get new preference names in such a case, the benefit to reuse old names is minor (and the old system was ugly).
Reporter | ||
Updated•11 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Reporter | ||
Updated•10 years ago
|
Assignee: mak77 → nobody
Status: ASSIGNED → NEW
Whiteboard: [good-first-bug][mentor=mak][lang=cpp]
Reporter | ||
Comment 5•10 years ago
|
||
Exactly like that :) So, the idea here is to add a Schema Migration in Database.h/cpp (http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/Database.cpp) to clear these old preferences
Assignee: nobody → katzelad
Status: NEW → ASSIGNED
Reporter | ||
Comment 6•10 years ago
|
||
The introduction reference is at https://developer.mozilla.org/en-US/docs/Introduction if you need any info on how to get code, build prerequisites and such. For any other question feel free to ask here, in #introduction or #fx-team on moznet
Updated•10 years ago
|
Whiteboard: [good-first-bug][mentor=mak][lang=cpp] → [good first bug][mentor=mak][lang=cpp]
Assignee | ||
Updated•10 years ago
|
Mentor: mak77
Whiteboard: [good first bug][mentor=mak][lang=cpp] → [good first bug][lang=cpp]
Reporter | ||
Comment 7•9 years ago
|
||
unassigning since we didn't hear back from the assignee recently
Assignee: katzelad → nobody
Reporter | ||
Updated•8 years ago
|
Status: ASSIGNED → NEW
Comment 8•8 years ago
|
||
Hi, I was taking a look at this in the Database.cpp file. Does this have a schema version number? Also, I found some lines are are similar to removing preferences in the file. Is it something like this? (void)Preferences::ClearUser("browser.history_expire_sites"); I found this line in the Database.cpp file. (void)Preferences::ClearUser("browser.bookmarks.livemark_refresh_seconds");
Reporter | ||
Comment 10•8 years ago
|
||
(In reply to thomasleong3 from comment #8) > Hi, I was taking a look at this in the Database.cpp file. Does this have a > schema version number? Yes, it's in Database.h > Also, I found some lines are are similar to removing preferences in the > file. Is it something like this? > (void)Preferences::ClearUser("browser.history_expire_sites"); yes. the fact is, on a second thought, I think this should be fixed when we actually will need to do a schema bump... It will happen sooner or later. Doing a schema bump just for this is expensive. So, I think I'm going to WONTFIX this, and will try to remember next time I write a schema migration to also clear some prefs... Sorry for late reply, I hope you can find a better bug to work on, please have a look at http://www.joshmatthews.net/bugsahoy/
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(mak77)
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•