Closed Bug 703127 Opened 8 years ago Closed 8 years ago

Remove unused files from /mobile/android

Categories

(Firefox for Android :: General, defect, P5)

All
Android
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

Attachments

(2 files)

We're shipping a bunch of files in native Fennec that are not used.  This makes it harder to search through the source code, and it bloats our package size by close to a megabyte, and might also hurt our startup time a bit.

These patches begin the work of removing all the dead files.  (NOTE: These files are scheduled to move to /mobile/android tomorrow; I'll wait for that move and rebase these patches before landing them.)
Attachment #575020 - Flags: review?(mark.finkle)
This isn't anywhere near complete, but it's a large start.  There's a lot more XBL and CSS that can be removed.  Removing config.xul (bug 699418) will help us remove some more files wholesale (it's the last place that browser.css is used).

We'll also need to get rid of most of the current files in chrome/tests at some point, and I'm sure there's other stuff I'm missing.
Attachment #575021 - Flags: review?(mark.finkle)
Comment on attachment 575020 [details] [diff] [review]
part 1: JS and XUL

* CharsetMenu will need to be re-impled anyway
* ContextCommands will be trimmed down quite a bit too
* We have been pulling stuff out of Utils.js anyway
* I think Fabrice is re-working OpenWebApps too
* We might end up with some lazy loading again, like that found in browser-scripts
* You could probably remove more from chrome/content/browser.css
Attachment #575020 - Flags: review?(mark.finkle) → review+
Comment on attachment 575021 [details] [diff] [review]
part 2: XBL, CSS, and images

* themes/core/images/remotetabs-32.png  is used in aboutHome, which is on the chopping block anyway, I guess.
Attachment #575021 - Flags: review?(mark.finkle) → review+
mentioned this to matt on irc.  please do not land until after the hg move tomorrow.
(In reply to Mark Finkle (:mfinkle) from comment #2)

> part 1: JS and XUL
> * I think Fabrice is re-working OpenWebApps too

That's correct. We can remove the ones from fennec/xul.
Priority: -- → P5
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
https://hg.mozilla.org/projects/birch/rev/a36e1ad44e6c
https://hg.mozilla.org/projects/birch/rev/92f5345081e9

We can file follow-up bugs for any additional cleanup.  Now that bug 699418 is fixed, we could get rid of platform.css and any files it references...
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Depends on: 708085
You need to log in before you can comment on or make changes to this bug.