703167 - Log the plugin package name when we fail to find it

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

We've seen a few "package not found" errors when trying to load the Flash plugin, but we aren't logging the package name that it tried. Let's fix that.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Log the plugin package name when we can't find it

Comment 3

[Erin Lancaster [:elan]]

a great site to test this with is http://foreigncinema.com; I'll be happy to uninstall flash and verify this once your patch lands.

Comment 4

[Erin Lancaster [:elan]]

Steps to repro
1) Install on a fresh, out of the box, Galaxy S2 (without flash bundled): android/1321469028/fennec-11.0a1.en-US.android-arm.apk
2) Go to http://foreigncinema.com
3) Crash 
4) Android Market/Download and Install FlashPlayer v11
5) Go to http://foreigncinema.com
Results: content loads, no crash

6) Uninstall Flash-it doesn't let you, it only lets you downgrade to v10, it acts as if flash has been bundled on the phone the whole time.

Comment 5

[Erin Lancaster [:elan]]

7)Go to back http://foreigncinema.com and you get an icon with "plugins required" graphic

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

It turns out we were always logging the package name; it's in the exception message.