Closed
Bug 703197
Opened 14 years ago
Closed 14 years ago
Printing a display:none iframe should work
Categories
(Core :: Printing: Setup, defect)
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
()
Details
Attachments
(1 file)
1.17 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Loading the attached url should pop up a print dialog and let you print.
![]() |
Assignee | |
Comment 1•14 years ago
|
||
Attachment #575117 -
Flags: review?
![]() |
Assignee | |
Updated•14 years ago
|
Attachment #575117 -
Flags: review? → review?(bugs)
Updated•14 years ago
|
Attachment #575117 -
Flags: review?(bugs) → review+
![]() |
Assignee | |
Comment 2•14 years ago
|
||
Flags: in-testsuite?
Whiteboard: [need review]
Target Milestone: --- → mozilla11
Comment 3•14 years ago
|
||
Comment on attachment 575117 [details] [diff] [review]
Make window.print() work in display:none iframes.
>- nsCOMPtr<nsIPresShell> presShell;
>- docShell->GetPresShell(getter_AddRefs(presShell));
>- if (!presShell || !mDocument || !mDeviceContext) {
>+ if (!mDocument || !mDeviceContext) {
> PR_PL(("Can't Print without pres shell, document etc"));
Is that log message still correct, after you've removed the check for presShell?
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
![]() |
Assignee | |
Comment 5•14 years ago
|
||
> Is that log message still correct, after you've removed the check for presShell?
Nope. Good catch. I'll fix that.
![]() |
Assignee | |
Comment 6•14 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c45c9b2cc0c for the message fix
Comment 7•14 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•