Printing a display:none iframe should work

RESOLVED FIXED in mozilla11

Status

()

Core
Printing: Setup
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

9 Branch
mozilla11
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

Loading the attached url should pop up a print dialog and let you print.
Created attachment 575117 [details] [diff] [review]
Make window.print() work in display:none iframes.
Attachment #575117 - Flags: review?
Attachment #575117 - Flags: review? → review?(bugs)

Updated

6 years ago
Attachment #575117 - Flags: review?(bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4fcfc45b674
Flags: in-testsuite?
Whiteboard: [need review]
Target Milestone: --- → mozilla11

Comment 3

6 years ago
Comment on attachment 575117 [details] [diff] [review]
Make window.print() work in display:none iframes.

>-  nsCOMPtr<nsIPresShell> presShell;
>-  docShell->GetPresShell(getter_AddRefs(presShell));
>-  if (!presShell || !mDocument || !mDeviceContext) {
>+  if (!mDocument || !mDeviceContext) {
>     PR_PL(("Can't Print without pres shell, document etc"));
Is that log message still correct, after you've removed the check for presShell?

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/e4fcfc45b674
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
> Is that log message still correct, after you've removed the check for presShell?

Nope.  Good catch.  I'll fix that.
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c45c9b2cc0c for the message fix

Comment 7

6 years ago
https://hg.mozilla.org/mozilla-central/rev/4c45c9b2cc0c
You need to log in before you can comment on or make changes to this bug.