703197 - Printing a display:none iframe should work

Status: RESOLVED FIXED

Description

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

Loading the attached url should pop up a print dialog and let you print.

Comment 1

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

Created attachment 575117 [details] [diff] [review]
Make window.print() work in display:none iframes.

Comment 2

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e4fcfc45b674

Comment 3

[Steffen Wilberg]

Comment on attachment 575117 [details] [diff] [review]
Make window.print() work in display:none iframes.

>-  nsCOMPtr<nsIPresShell> presShell;
>-  docShell->GetPresShell(getter_AddRefs(presShell));
>-  if (!presShell || !mDocument || !mDeviceContext) {
>+  if (!mDocument || !mDeviceContext) {
>     PR_PL(("Can't Print without pres shell, document etc"));
Is that log message still correct, after you've removed the check for presShell?

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e4fcfc45b674

Comment 5

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

> Is that log message still correct, after you've removed the check for presShell?

Nope.  Good catch.  I'll fix that.

Comment 6

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4c45c9b2cc0c for the message fix

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4c45c9b2cc0c