Comment 1 Boris Zbarsky [:bz] (still a bit busy) 2011-11-17 01:34:25 PST

Created attachment 575117 [details] [diff] [review]
Make window.print() work in display:none iframes.

Comment 2 Boris Zbarsky [:bz] (still a bit busy) 2011-11-17 19:55:06 PST

https://hg.mozilla.org/integration/mozilla-inbound/rev/e4fcfc45b674

Comment 3 Steffen Wilberg 2011-11-18 02:37:34 PST

Comment on attachment 575117 [details] [diff] [review]
Make window.print() work in display:none iframes.

>-  nsCOMPtr<nsIPresShell> presShell;
>-  docShell->GetPresShell(getter_AddRefs(presShell));
>-  if (!presShell || !mDocument || !mDeviceContext) {
>+  if (!mDocument || !mDeviceContext) {
>     PR_PL(("Can't Print without pres shell, document etc"));
Is that log message still correct, after you've removed the check for presShell?

Comment 4 Ed Morley [:emorley] 2011-11-18 02:58:27 PST

https://hg.mozilla.org/mozilla-central/rev/e4fcfc45b674

Comment 5 Boris Zbarsky [:bz] (still a bit busy) 2011-11-18 03:33:45 PST

> Is that log message still correct, after you've removed the check for presShell?

Nope.  Good catch.  I'll fix that.

Comment 6 Boris Zbarsky [:bz] (still a bit busy) 2011-11-19 15:07:18 PST

https://hg.mozilla.org/integration/mozilla-inbound/rev/4c45c9b2cc0c for the message fix

Comment 7 Ed Morley [:emorley] 2011-11-20 14:21:32 PST

https://hg.mozilla.org/mozilla-central/rev/4c45c9b2cc0c