Closed
Bug 703232
Opened 14 years ago
Closed 13 years ago
Clean up mozconfigs a bit (port bug 575283), remove some default options, enable signmar testing, and disable auto deps on Windows nightly builds
Categories
(Thunderbird :: Build Config, defect)
Thunderbird
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 15.0
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file, 1 obsolete file)
11.09 KB,
patch
|
jhopkins
:
review+
|
Details | Diff | Splinter Review |
Bug 575283 did a whole load of cleanup in mozconfigs to remove default options.
I'd like to do that for us as well, before we do bug 685166 (then it doesn't need doing in two different places).
However, for now I'm just doing the comm-central files - we can port the changes across as we go through the merge processes.
Attachment #575136 -
Flags: review?(jhopkins)
Assignee | ||
Comment 1•14 years ago
|
||
Comment on attachment 575136 [details] [diff] [review]
The fix
I just realised - we still need MOZ_DEBUG_SYMBOLS for ldap. I'm going to take a look and see if we can fix that up to not need it.
Attachment #575136 -
Flags: review?(jhopkins)
Assignee | ||
Comment 2•13 years ago
|
||
Taking across to Thunderbird product, we'll do this there now the configs are in-tree.
Assignee: nobody → mbanner
Component: Release Engineering → Build Config
Product: Mozilla Messaging → Thunderbird
QA Contact: release → build-config
Version: other → Trunk
Assignee | ||
Updated•13 years ago
|
Summary: Clean up mozconfigs a bit (port bug 575283) → Clean up mozconfigs a bit (port bug 575283), remove some default options, enable signmar testing, and disable auto deps on Windows nightly builds
Assignee | ||
Comment 3•13 years ago
|
||
This does several things:
- Remove options that are the default, e.g. --enable-optimize, --disable-debug, --enable-tests
- Adds signmar to all the debug & nightly mozconfigs. This enables the signmar tests, but doesn't add anything to the final build. Just a sanity thing.
- Aligns the mozconfigs closer to the Firefox in-tree ones, so that the diffs are as minimal as I want to make them at this stage.
- Adds the --disable-auto-deps to IS_NIGHTLY builds on Windows so that nightly builds (and try once bug 759079 is fixed) don't build with autodeps, which is meant to mean faster builds.
Attachment #575136 -
Attachment is obsolete: true
Attachment #627739 -
Flags: review?(jhopkins)
Updated•13 years ago
|
Attachment #627739 -
Flags: review?(jhopkins) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
Assignee | ||
Comment 5•13 years ago
|
||
p.s. I'll raise bugs for the other diffs as I get to them.
You need to log in
before you can comment on or make changes to this bug.
Description
•