703232 - Clean up mozconfigs a bit (port bug 575283), remove some default options, enable signmar testing, and disable auto deps on Windows nightly builds

Status: RESOLVED FIXED

Description

[Mark Banner (:standard8) (afk until Friday)]

Created attachment 575136 [details] [diff] [review]
The fix

Bug 575283 did a whole load of cleanup in mozconfigs to remove default options.

I'd like to do that for us as well, before we do bug 685166 (then it doesn't need doing in two different places).

However, for now I'm just doing the comm-central files - we can port the changes across as we go through the merge processes.

Comment 1

[Mark Banner (:standard8) (afk until Friday)]

Comment on attachment 575136 [details] [diff] [review]
The fix

I just realised - we still need MOZ_DEBUG_SYMBOLS for ldap. I'm going to take a look and see if we can fix that up to not need it.

Comment 2

[Mark Banner (:standard8) (afk until Friday)]

Taking across to Thunderbird product, we'll do this there now the configs are in-tree.

Comment 3

[Mark Banner (:standard8) (afk until Friday)]

Created attachment 627739 [details] [diff] [review]
The fix v2

This does several things:

- Remove options that are the default, e.g. --enable-optimize, --disable-debug, --enable-tests
- Adds signmar to all the debug & nightly mozconfigs. This enables the signmar tests, but doesn't add anything to the final build. Just a sanity thing.
- Aligns the mozconfigs closer to the Firefox in-tree ones, so that the diffs are as minimal as I want to make them at this stage.
- Adds the --disable-auto-deps to IS_NIGHTLY builds on Windows so that nightly builds (and try once bug 759079 is fixed) don't build with autodeps, which is meant to mean faster builds.

Comment 4

[Mark Banner (:standard8) (afk until Friday)]

Checked in: https://hg.mozilla.org/comm-central/rev/af5aee67d0c8

Comment 5

[Mark Banner (:standard8) (afk until Friday)]

p.s. I'll raise bugs for the other diffs as I get to them.