Last Comment Bug 703232 - Clean up mozconfigs a bit (port bug 575283), remove some default options, enable signmar testing, and disable auto deps on Windows nightly builds
: Clean up mozconfigs a bit (port bug 575283), remove some default options, ena...
Product: Thunderbird
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: All All
-- normal (vote)
: Thunderbird 15.0
Assigned To: Mark Banner (:standard8)
Depends on: 737028
Blocks: 685166
  Show dependency treegraph
Reported: 2011-11-17 03:14 PST by Mark Banner (:standard8)
Modified: 2012-05-28 14:13 PDT (History)
1 user (show)
standard8: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

The fix (9.70 KB, patch)
2011-11-17 03:14 PST, Mark Banner (:standard8)
no flags Details | Diff | Splinter Review
The fix v2 (11.09 KB, patch)
2012-05-28 09:48 PDT, Mark Banner (:standard8)
jhopkins: review+
Details | Diff | Splinter Review

Description User image Mark Banner (:standard8) 2011-11-17 03:14:25 PST
Created attachment 575136 [details] [diff] [review]
The fix

Bug 575283 did a whole load of cleanup in mozconfigs to remove default options.

I'd like to do that for us as well, before we do bug 685166 (then it doesn't need doing in two different places).

However, for now I'm just doing the comm-central files - we can port the changes across as we go through the merge processes.
Comment 1 User image Mark Banner (:standard8) 2011-11-17 05:57:40 PST
Comment on attachment 575136 [details] [diff] [review]
The fix

I just realised - we still need MOZ_DEBUG_SYMBOLS for ldap. I'm going to take a look and see if we can fix that up to not need it.
Comment 2 User image Mark Banner (:standard8) 2012-05-09 06:53:17 PDT
Taking across to Thunderbird product, we'll do this there now the configs are in-tree.
Comment 3 User image Mark Banner (:standard8) 2012-05-28 09:48:53 PDT
Created attachment 627739 [details] [diff] [review]
The fix v2

This does several things:

- Remove options that are the default, e.g. --enable-optimize, --disable-debug, --enable-tests
- Adds signmar to all the debug & nightly mozconfigs. This enables the signmar tests, but doesn't add anything to the final build. Just a sanity thing.
- Aligns the mozconfigs closer to the Firefox in-tree ones, so that the diffs are as minimal as I want to make them at this stage.
- Adds the --disable-auto-deps to IS_NIGHTLY builds on Windows so that nightly builds (and try once bug 759079 is fixed) don't build with autodeps, which is meant to mean faster builds.
Comment 4 User image Mark Banner (:standard8) 2012-05-28 14:11:28 PDT
Checked in:
Comment 5 User image Mark Banner (:standard8) 2012-05-28 14:13:23 PDT
p.s. I'll raise bugs for the other diffs as I get to them.

Note You need to log in before you can comment on or make changes to this bug.