Clean up mozconfigs a bit (port bug 575283), remove some default options, enable signmar testing, and disable auto deps on Windows nightly builds

RESOLVED FIXED in Thunderbird 15.0

Status

defect
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 15.0
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

8 years ago
Posted patch The fix (obsolete) — Splinter Review
Bug 575283 did a whole load of cleanup in mozconfigs to remove default options.

I'd like to do that for us as well, before we do bug 685166 (then it doesn't need doing in two different places).

However, for now I'm just doing the comm-central files - we can port the changes across as we go through the merge processes.
Attachment #575136 - Flags: review?(jhopkins)
Assignee

Updated

8 years ago
Blocks: 685166
Assignee

Comment 1

8 years ago
Comment on attachment 575136 [details] [diff] [review]
The fix

I just realised - we still need MOZ_DEBUG_SYMBOLS for ldap. I'm going to take a look and see if we can fix that up to not need it.
Attachment #575136 - Flags: review?(jhopkins)
Assignee

Updated

7 years ago
Depends on: 737028
Assignee

Comment 2

7 years ago
Taking across to Thunderbird product, we'll do this there now the configs are in-tree.
Assignee: nobody → mbanner
Component: Release Engineering → Build Config
Product: Mozilla Messaging → Thunderbird
QA Contact: release → build-config
Version: other → Trunk
Assignee

Updated

7 years ago
Summary: Clean up mozconfigs a bit (port bug 575283) → Clean up mozconfigs a bit (port bug 575283), remove some default options, enable signmar testing, and disable auto deps on Windows nightly builds
Assignee

Comment 3

7 years ago
Posted patch The fix v2Splinter Review
This does several things:

- Remove options that are the default, e.g. --enable-optimize, --disable-debug, --enable-tests
- Adds signmar to all the debug & nightly mozconfigs. This enables the signmar tests, but doesn't add anything to the final build. Just a sanity thing.
- Aligns the mozconfigs closer to the Firefox in-tree ones, so that the diffs are as minimal as I want to make them at this stage.
- Adds the --disable-auto-deps to IS_NIGHTLY builds on Windows so that nightly builds (and try once bug 759079 is fixed) don't build with autodeps, which is meant to mean faster builds.
Attachment #575136 - Attachment is obsolete: true
Attachment #627739 - Flags: review?(jhopkins)
Attachment #627739 - Flags: review?(jhopkins) → review+
Assignee

Comment 4

7 years ago
Checked in: https://hg.mozilla.org/comm-central/rev/af5aee67d0c8
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
Assignee

Comment 5

7 years ago
p.s. I'll raise bugs for the other diffs as I get to them.
You need to log in before you can comment on or make changes to this bug.