703290 - html tags in comments break the page

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Kadir Topal [:atopal]]

If you add html tags/brackets into a comment section anything beyond that comment is not rendered anymore.

reduced testcase:
<!-- <x -->


STR:

Above comment
<!-- <x -->
Whatever comes here

displays as:

Above comment


Expected:

Above comment
Whatever comes here

Comment 1

[Kadir Topal [:atopal]]

Not caused by broken HTML, <!-- <div></div> --> trips it up as well

Comment 2

[Alice Wyman]

Related discussion:

https://support.mozilla.com/en-US/forums/knowledge-base-articles/707808

Comment 3

[Erik Rose [:erik][:erikrose]]

Does anybody care if the comment gets removed in the rendered HTML? If not, I can fix this right quick. (The comment will still, of course, show in the edit mode.)

Comment 4

[Alice Wyman]

A <!--comment--> is not supposed to show in the rendered article.  It might contain HTML or wiki markup (e.g, curly brackets as in {for} or  double brackets as in [[article]] or [[Image:]] links) to "comment out" a part of the article that you don't want to be displayed.  For example, <!-- {for winxp}<br/> <br/> [[Image:controlPanel-resized.png]] <br/>{/for} --> was added as a comment in https://support.mozilla.com/en-US/kb/Uninstalling%20Firefox/revision/16140 because the Windows XP screenshot was replaced with a Windows 7 screenshot.  The editor wanted to keep the Windows XP screenshot markup in a comment because of the pending bug 651226 (Add 'winxp' and 'win7' to showfor).  

If you can fix this right away I think you should.  Who knows what other articles contain comments that are hiding the rest of the article.

Comment 5

[Erik Rose [:erik][:erikrose]]

master: http://github.com/jsocol/kitsune/commit/82ee116
next: http://github.com/jsocol/kitsune/commit/d6ed2ea

QA: We should probably run quite a bit of representative markup through the renderer to make sure this didn't have any unintended side effects; the parser is not well understood and is subject to nonlinear effects. ;-) Using the Preview button is probably the easiest way.

Comment 6

[Rebecca Billings [:rbillings]]

Verified all buttons and basic markup + the examples above all function as expected.