Gonk got broken by some changes in m-c.
Created attachment 575223 [details] [diff] [review]
Fix build/crash in gonk
Created attachment 575226 [details] [diff] [review]
This handles the windows a little more carefully so we don't get black screens and we only try to draw one window.
So in theory things should work again with the change you made to disable the addon code backed out?
Can you post a patch for that backout so I can test it?
It's backed out on github -
Ah, I see, and the fix has also landed on github.
I don't understand this code well enough to feel comfortable giving a proper review. But it's certainly an f+, as it works great for me.
Comment on attachment 575226 [details] [diff] [review]
The change to Invalidate() should be OK as long as we completely invalidate windows when they go hidden->visible, which I believe is the case.
This could have caused a perf regression. Please have a look at dev.tree-management:
> Talos Regression :( Tp5 MozAfterPaint (Private Bytes) increase 2.73% on Linux Firefox-Non-PGO
> Talos Regression :( Tp5 MozAfterPaint (Private Bytes) increase 2.61% on Linux x64 Firefox-Non-PGO