Last Comment Bug 703307 - Make gonk work (build/start/draw) again
: Make gonk work (build/start/draw) again
Product: Core
Classification: Components
Component: Widget (show other bugs)
: unspecified
: All Gonk (Firefox OS)
: -- normal (vote)
: mozilla11
Assigned To: Michael Wu [:mwu]
Depends on:
  Show dependency treegraph
Reported: 2011-11-17 10:29 PST by Michael Wu [:mwu]
Modified: 2012-02-01 13:56 PST (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Fix build/crash in gonk (2.22 KB, patch)
2011-11-17 10:37 PST, Michael Wu [:mwu]
cjones.bugs: review+
Details | Diff | Splinter Review
Fix blackscreen (959 bytes, patch)
2011-11-17 10:41 PST, Michael Wu [:mwu]
cjones.bugs: review+
justin.lebar+bug: feedback+
Details | Diff | Splinter Review

Description Michael Wu [:mwu] 2011-11-17 10:29:20 PST
Gonk got broken by some changes in m-c.
Comment 1 Michael Wu [:mwu] 2011-11-17 10:37:29 PST
Created attachment 575223 [details] [diff] [review]
Fix build/crash in gonk
Comment 2 Michael Wu [:mwu] 2011-11-17 10:41:08 PST
Created attachment 575226 [details] [diff] [review]
Fix blackscreen

This handles the windows a little more carefully so we don't get black screens and we only try to draw one window.
Comment 3 Justin Lebar (not reading bugmail) 2011-11-17 10:51:33 PST
So in theory things should work again with the change you made to disable the addon code backed out?

Can you post a patch for that backout so I can test it?
Comment 4 Michael Wu [:mwu] 2011-11-17 11:03:42 PST
It's backed out on github -
Comment 5 Justin Lebar (not reading bugmail) 2011-11-17 14:44:00 PST
Ah, I see, and the fix has also landed on github.

I don't understand this code well enough to feel comfortable giving a proper review.  But it's certainly an f+, as it works great for me.
Comment 6 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-11-17 15:31:14 PST
Comment on attachment 575226 [details] [diff] [review]
Fix blackscreen

The change to Invalidate() should be OK as long as we completely invalidate windows when they go hidden->visible, which I believe is the case.
Comment 9 Armen Zambrano [:armenzg] (EDT/UTC-4) 2011-11-24 07:37:17 PST
This could have caused a perf regression. Please have a look at dev.tree-management:
> Talos Regression :( Tp5 MozAfterPaint (Private Bytes) increase 2.73% on Linux Firefox-Non-PGO
> Talos Regression :( Tp5 MozAfterPaint (Private Bytes) increase 2.61% on Linux x64 Firefox-Non-PGO

Note You need to log in before you can comment on or make changes to this bug.