Make gonk work (build/start/draw) again

RESOLVED FIXED in mozilla11

Status

()

Core
Widget
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mwu, Assigned: mwu)

Tracking

unspecified
mozilla11
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Gonk got broken by some changes in m-c.
(Assignee)

Comment 1

6 years ago
Created attachment 575223 [details] [diff] [review]
Fix build/crash in gonk
Attachment #575223 - Flags: review?(jones.chris.g)
(Assignee)

Comment 2

6 years ago
Created attachment 575226 [details] [diff] [review]
Fix blackscreen

This handles the windows a little more carefully so we don't get black screens and we only try to draw one window.
Attachment #575226 - Flags: review?(justin.lebar+bug)
So in theory things should work again with the change you made to disable the addon code backed out?

Can you post a patch for that backout so I can test it?
(Assignee)

Comment 4

6 years ago
It's backed out on github -

https://github.com/cgjones/mozilla-central/commit/39f144c08382f7df574a0b805fea5834f637766d
Ah, I see, and the fix has also landed on github.

I don't understand this code well enough to feel comfortable giving a proper review.  But it's certainly an f+, as it works great for me.
Attachment #575226 - Flags: review?(justin.lebar+bug) → feedback+
Attachment #575223 - Flags: review?(jones.chris.g) → review+
Comment on attachment 575226 [details] [diff] [review]
Fix blackscreen

The change to Invalidate() should be OK as long as we completely invalidate windows when they go hidden->visible, which I believe is the case.
Attachment #575226 - Flags: review+
(Assignee)

Comment 7

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf7d8d1db3c1
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd6df33101a6

Comment 8

6 years ago
https://hg.mozilla.org/mozilla-central/rev/cf7d8d1db3c1
https://hg.mozilla.org/mozilla-central/rev/bd6df33101a6
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
This could have caused a perf regression. Please have a look at dev.tree-management:
> Talos Regression :( Tp5 MozAfterPaint (Private Bytes) increase 2.73% on Linux Firefox-Non-PGO
> Talos Regression :( Tp5 MozAfterPaint (Private Bytes) increase 2.61% on Linux x64 Firefox-Non-PGO
You need to log in before you can comment on or make changes to this bug.