703315 - Add Thunderbird to graph server

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[John Hopkins (:jhopkins)]

We need to add Thunderbird to the graph server.

Comment 1

[John Hopkins (:jhopkins)]

Attachment: changes to http://hg.mozilla.org/graphs

Comment 2

[John Hopkins (:jhopkins)]

Hal: what prompted this bug is the following error message in a failed buildbot build log (on staging):

> No machine_name called 'Linux_comm-central' can be found File "/var/www/html/graphs2/server/pyfomatic/collect.py"

Aki provided these instructions: 

1. check out http://hg.mozilla.org/graphs
2. update to 1.0 branch
3. edit sql/data.sql, e.g.

http://hg.mozilla.org/graphs/rev/3d1e1a7132aa [see below]

which adds a branch and the machines for it.  If comm-central already exists as a branch, you need to add the machine(s).
The top of the machines insert commands should have the column names; otherwise it's kind of obscure.

4. get review
5. add the raw sql to an IT bug to apply to graphs-stage.
6. ping IT to fix the bug if it's needed in more than a few days.

Comment 4

[Hal Wine [:hwine] use NI!]

Comment on attachment 575244 [details] [diff] [review]
changes to http://hg.mozilla.org/graphs

looks reasonable

Comment 5

[John Hopkins (:jhopkins)]

Comment on attachment 575244 [details] [diff] [review]
changes to http://hg.mozilla.org/graphs

Review of attachment 575244 [details] [diff] [review]:
-----------------------------------------------------------------

Landed in http://hg.mozilla.org/graphs/rev/370408b1cbf1

Comment 6

[Hal Wine [:hwine] use NI!]

While DB update has been applied to both staging and production, there were some duplicates. Apparently, both Thunderbird and SeaMonkey lay claim to the same names:
 Linux_comm-aurora
 Linux_comm-aurora_leak_test
 WINNT_5.2_comm-aurora
 WINNT_5.2_comm-aurora_leak_test
 WINNT_5.2_comm-beta
 WINNT_5.2_comm-beta_leak_test

All 6 of these come from both:
$ hg log -r352 -r 372 data.sql 
changeset:   352:60e1136a3551
branch:      1.0
user:        Justin Wood <[e-mail]>
date:        Tue May 24 23:43:52 2011 -0400
summary:     Bug 659225 - Update data.sql in graphserver for new SeaMonkey rapid-release. r=bhearsum

changeset:   372:370408b1cbf1
branch:      1.0
tag:         tip
user:        John Hopkins <[e-mail]>
date:        Wed Nov 30 13:35:20 2011 -0500
summary:     Bug 703315 - Add Thunderbird to graph server. r=hwine

At this moment, data.sql has the duplicates but the real databases do not.

Comment 7

[John Hopkins (:jhopkins)]

Thanks, Hal.  What are our options for handling the duplicates?  We could munge the builder names, but that seems more like a workaround than a solution.  Change the graph server database and reports so that product becomes part of the unique identifier?  I've no idea how much work that would entail.

Comment 8

[John Hopkins (:jhopkins)]

Resolving the duplicate entries is being tracked in bug 710269.

Comment 9

[John Hopkins (:jhopkins)]

I don't see Thunderbird here: http://graphs-stage.mozilla.org/

Comment 10

[Chris Cooper [:coop] (he/him)]

(In reply to John Hopkins (:jhopkins) from comment #8)
> Resolving the duplicate entries is being tracked in bug 710269.

Given bug 710269, resolving this bug in favor of having graphs-stage updated to match graphs.mozilla.org (bug 713104).