70334 - Personal Toolbar Folder not properly migrated on DBCS systems

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Mike Kaply [:mkaply]]

On DBCS systems, the Personal Toolbar Folder is not migrated from 4.x folders.

The reason is this line:

http://lxr.mozilla.org/seamonkey/source/xpfe/components/bookmarks/src/nsBookmark
sService.cpp#1662

mPersonalToolbarName.AssignWithConversion(prefVal);

prefVal is UTF8 so using AssignWithConversion is wrong.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Fix - use UTF8 conversion

Comment 2

[Mike Kaply [:mkaply]]

Can I just get a review on this please?

Comment 3

[Chris Waterson]

r=waterson. alecf, care to sr=?

Comment 4

[Alec Flett]

sr=alecf

Comment 5

[Mike Kaply [:mkaply]]

Fix checked in

Comment 6

[Claudius Gayle]

What's a DBCS system - or more precisely do I have any hope of verifying this on the
standard platforms?
I'm looking for steps here (or someone to stake their name and reputation that this bug
is verified fixed).

Comment 7

[Mike Kaply [:mkaply]]

Actually, this can be done on non DBCS systems as well.

What you are looking for is a 4.x version of Netscape where the name of the 
Personal Toolbar Folder contains a special character.

I'm not sure which NLV versions translate Personal Toolbar Folder this way.

Then you migrate that profile with Mozilla, and you will see that it is not 
properly migrated.

BTW, a DBCS system is Japanese or Chinese, and I'm sure Frank Tang has one of 
those lying around. It's easier to test this there because Personal Toolbar 
Folder is entirely Japanese or Chinese characters.

Comment 8

[Mike Kaply [:mkaply]]

This is fixed