All users were logged out of Bugzilla on October 13th, 2018

Personal Toolbar Folder not properly migrated on DBCS systems

VERIFIED FIXED

Status

VERIFIED FIXED
18 years ago
14 years ago

People

(Reporter: mkaply, Assigned: bugs)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
On DBCS systems, the Personal Toolbar Folder is not migrated from 4.x folders.

The reason is this line:

http://lxr.mozilla.org/seamonkey/source/xpfe/components/bookmarks/src/nsBookmark
sService.cpp#1662

mPersonalToolbarName.AssignWithConversion(prefVal);

prefVal is UTF8 so using AssignWithConversion is wrong.
(Reporter)

Comment 1

18 years ago
Created attachment 26283 [details] [diff] [review]
Fix - use UTF8 conversion
(Reporter)

Comment 2

18 years ago
Can I just get a review on this please?
Keywords: patch, review

Comment 3

18 years ago
r=waterson. alecf, care to sr=?

Comment 4

18 years ago
sr=alecf
(Reporter)

Comment 5

18 years ago
Fix checked in
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 6

18 years ago
What's a DBCS system - or more precisely do I have any hope of verifying this on the
standard platforms?
I'm looking for steps here (or someone to stake their name and reputation that this bug
is verified fixed).
(Reporter)

Comment 7

18 years ago
Actually, this can be done on non DBCS systems as well.

What you are looking for is a 4.x version of Netscape where the name of the 
Personal Toolbar Folder contains a special character.

I'm not sure which NLV versions translate Personal Toolbar Folder this way.

Then you migrate that profile with Mozilla, and you will see that it is not 
properly migrated.

BTW, a DBCS system is Japanese or Chinese, and I'm sure Frank Tang has one of 
those lying around. It's easier to test this there because Personal Toolbar 
Folder is entirely Japanese or Chinese characters.
(Reporter)

Comment 8

17 years ago
This is fixed
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.