Closed Bug 703349 Opened 13 years ago Closed 13 years ago

Switch Android nightly users to use Birch builds on Tuesday, November 22

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mozilla, Assigned: nthomas)

References

Details

Attachments

(1 file)

fennec nightly -> birch
1.03 KB, patch
nthomas
: review+
nthomas
: checked-in+
Details | Diff | Splinter Review 
Pending ok/go from dougt, mfinkle, legneato, or smooney.
As mentioned in IRC, this patch will shunt all nightly users (currently on mozilla-central) to birch.

It will most likely *also* permanently change their update channel to 'nightly-birch', since we're using apk's instead of mar's on Android.

This means that when we want to point users back at mozilla-central, we will need to take *all* birch users and point them back at mozilla-central.

I think this will be acceptable behavior, but I'm noting this here for clarity.
Attachment #575284 - Flags: review?(nrthomas)
Aiui, this will also happen ~immediately when IT lands this change.

So on Tuesday, I recommend

a) merge from m-c -> birch
b) trigger another Android birch nightly
c) verify this nightly looks good
d) land, tag, and have IT roll out this AUS change, at which point anyone checking for updates on the nightly channel will get the latest birch nightly.
Comment on attachment 575284 [details] [diff] [review]
fennec nightly -> birch

This looks fine, but lets figure out how we're going to block Honeycomb before r+ing it.
Comment on attachment 575284 [details] [diff] [review]
fennec nightly -> birch

Ok, so we're not actually gonna block honeycomb. I can do landing and IT bug on Tuesday, if the Pacific afternoon works for the mobile folks.
Attachment #575284 - Flags: review?(nrthomas) → review+
> Comment on attachment 575284 [details] [diff] [review] [diff] [details] [review]
> fennec nightly -> birch
> 
> Ok, so we're not actually gonna block honeycomb. I can do landing and IT bug
> on Tuesday, if the Pacific afternoon works for the mobile folks.

Why not? It isn't confirmed yet if we get the android version in the mobile update ping...I've asked QA to look into it.

(In reply to Aki Sasaki [:aki] from comment #1)

> As mentioned in IRC, this patch will shunt all nightly users (currently on
> mozilla-central) to birch.
> 
> It will most likely *also* permanently change their update channel to
> 'nightly-birch', since we're using apk's instead of mar's on Android.
> 
> This means that when we want to point users back at mozilla-central, we will
> need to take *all* birch users and point them back at mozilla-central.
> 
> I think this will be acceptable behavior, but I'm noting this here for
> clarity.

I think we want the opposite I think...birch to become nightly and nightly to become nightly-xul or something. When we merge back, we just make mozilla-central nightly again and make birch nightly-birch again.

Shouldn't that get around the channel issue? We won't have people going back from m-c to birch, so changing the channel permanently isn't a worry for the ex birch users.
(In reply to Christian Legnitto [:LegNeato] from comment #5)
> > Comment on attachment 575284 [details] [diff] [review] [diff] [details] [review] [diff] [details] [review]
> > fennec nightly -> birch
> > 
> > Ok, so we're not actually gonna block honeycomb. I can do landing and IT bug
> > on Tuesday, if the Pacific afternoon works for the mobile folks.
> 
> Why not? It isn't confirmed yet if we get the android version in the mobile
> update ping...I've asked QA to look into it.

This is extra work on our side, so advance notice is appreciated.

> (In reply to Aki Sasaki [:aki] from comment #1)
> 
> > As mentioned in IRC, this patch will shunt all nightly users (currently on
> > mozilla-central) to birch.
> > 
> > It will most likely *also* permanently change their update channel to
> > 'nightly-birch', since we're using apk's instead of mar's on Android.
> > 
> > This means that when we want to point users back at mozilla-central, we will
> > need to take *all* birch users and point them back at mozilla-central.
> > 
> > I think this will be acceptable behavior, but I'm noting this here for
> > clarity.
> 
> I think we want the opposite I think...birch to become nightly and nightly
> to become nightly-xul or something. When we merge back, we just make
> mozilla-central nightly again and make birch nightly-birch again.
> 
> Shouldn't that get around the channel issue? We won't have people going back
> from m-c to birch, so changing the channel permanently isn't a worry for the
> ex birch users.

If birch becomes 'nightly', birch users will ask AUS for the nightly update snippets, which will be mozilla-central (XUL) apks, which sounds like the opposite of what we want.

I think you mean you want birch to publish snippets to the mozilla-central directory.

This is making my head hurt.

Why is it important to be able to get birch users back on birch without manual intervention?  The sooner we get rid of birch the better imo, and leaving nightly users pointed at birch until that point seems like an acceptable solution.
(In reply to Christian Legnitto [:LegNeato] from comment #5)
> Why not? It isn't confirmed yet if we get the android version in the mobile
> update ping...I've asked QA to look into it.

Taking a Galaxy Tab 10.1 (w/ Android 3.1) and doing PR logging via adb shell [1] I get this for the request to AUS:
* the request is 
https://aus3.mozilla.org/update/4/Fennec/11.0a1/20111117074354/Android_arm-eabi-gcc3/en-US/nightly-birch/Linux%202.6.36.3/default/default/11.0a1/update.xml?force=1
with
User-Agent: Mozilla/5.0 (Android; Linux armv7l; rv:11.0a1) Gecko/20111117 Firefox/11.0a1 Fennec/11.0a1

So unless the kernel version in the query is unique there's nothing to key a block off. We can perhaps tweak what's in the query, but I'm not sure what proportion of users we'd have sending useful info before tuesday. Can dig in the metrics if you want.

[1] https://wiki.mozilla.org/Mobile/Fennec/Android#PR_Logging
(In reply to Aki Sasaki [:aki] from comment #6)
> (In reply to Christian Legnitto [:LegNeato] from comment #5)
> > I think we want the opposite I think...birch to become nightly and nightly
> > to become nightly-xul or something. When we merge back, we just make
> > mozilla-central nightly again and make birch nightly-birch again.
> > 
> > Shouldn't that get around the channel issue? We won't have people going back
> > from m-c to birch, so changing the channel permanently isn't a worry for the
> > ex birch users.
> 
> If birch becomes 'nightly', birch users will ask AUS for the nightly update
> snippets, which will be mozilla-central (XUL) apks, which sounds like the
> opposite of what we want.
> 
> I think you mean you want birch to publish snippets to the mozilla-central
> directory.
> 
> This is making my head hurt.

I think any way you manipulate channels and directory names, you have mozilla-central and birch users installing the same apk, correct? (In this case, the apk created from birch with Native UI.)

Installing the apk will change your channel to the channel in the apk.
It doesn't matter whether that channel is 'nightly', 'nightly-birch', or 'toesocks'; all users installing that apk will have that new channel at that point.
No matter how ugly we make the config here, if both sets of users install the same apk, both sets of users will be on the same channel afterwards.
Has the the initial request morphed to 
* move current nightly users over to birch
* for anyone installing a nightly xul build after the cutover keep them on m-c xul
now ?

What are the goals of getting people over on birch ? Maximum amount of testing ?
Ok, thanks for the info about the update URL. I'll investigate if the kernel version is unique, doubt it is.

(In reply to Nick Thomas [:nthomas] from comment #9)
> Has the the initial request morphed to 
> * move current nightly users over to birch
> * for anyone installing a nightly xul build after the cutover keep them on
> m-c xul
> now ?

No. Man I mucked this bug up :-)

> 
> What are the goals of getting people over on birch ? Maximum amount of
> testing ?

Yep. We just want users on NativeUI, which means taking "nightly" channel users and offering birch bits.


Ok, so my understanding is AUS has no concept of mozilla-central vs birch. I *think* what we want is birch snippets offered to users on the "nightly" channel and manual builds out of birch defaulting to "nightly" as well. It doesn't hurt to have mozilla-central / XUL manual builds default to "nightly", which would mean that anyone installing the XUL build will then get updated to Native UI (which is probably good from a testing standpoint).

So, did I mess this up enough? Does the patch give us what I describe above?
(In reply to Christian Legnitto [:LegNeato] from comment #10)
> Ok, so my understanding is AUS has no concept of mozilla-central vs birch. I
> *think* what we want is birch snippets offered to users on the "nightly"
> channel and manual builds out of birch defaulting to "nightly" as well. It
> doesn't hurt to have mozilla-central / XUL manual builds default to
> "nightly", which would mean that anyone installing the XUL build will then
> get updated to Native UI (which is probably good from a testing standpoint).
> 
> So, did I mess this up enough? Does the patch give us what I describe above?

I think the confusion is that we're not using MARs.

Desktop:

channel info is in installer
channel info is in profile
channel info is *not* in MARs
When you get a snippet, you download a MAR.

Therefore you're able to send any MAR to someone on any applicable channel and they'll stay on that channel.

Android, aiui from Nick's explanation to me in IRC:

channel info is in installer (apk)
When you get a snippet, you download an apk, and your new update channel is the one in the apk.

So the snippet above sends anyone on the nightly channel the birch apk.
However, once they install the birch apk, they change channels to nightly-birch.
When we want to switch back, we send nightly-birch users the mozilla-central apk.
Once they install the mozilla-central apk, they change channels to nightly.
The end result is we send XUL UI users the native UI build, but all nightly and nightly-birch users are on the same channel after that point.

I know you're going to ask "why can't we have birch upload to the mozilla-central snippet directory and have a nightly channel, so nightly users can install the birch apk but stay on the nightly channel", but that strands the birch users, who will get zero updates.  If they decide to install the latest birch apk, they immediately switch to the nightly channel.  If they don't, we strand those testers on an old build that we probably don't care about.  Merging the two channels doesn't seem so bad when you realize that everyone on nightly-birch chose to install it manually, and can do so again in the future if we want to split the channels again.
Ok, makes sense. I think the confusion was the apk stuff, as you said. Thanks for the clarity!
per irc with legneato:

The plan is to update *all* android users on mozilla-central nightlies to the latest birch nightly. Explicitly, no distinction is being made about native-UI-vs-xul-UI ; or about users on tablets-vs-phones.

Also, I've filed bug 703759 to track merging tip of mozilla-central onto birch before we migrate m-c nightly users to birch nightly. We discussed this in the meeting as being needed to 1) avoid m-c nightly users seeing "regression" if they were updated to birch that was using older m-c. 2) avoid complicating crash-stat analysis.
No longer depends on: 703759
Nick was kind enough to volunteer for this on Tuesday, should the 'go' come in the PST afternoon.  Thanks Nick!
Assignee: aki → nrthomas
Blocks: 704315
No longer blocks: 704315
Depends on: 704315
Ok, is there a "go" required here? I thought we were just going top let normal automation take care of it? I'll see if I can find nick on IRC.
Christian, I'm waiting for a go from you when we're all QA'd and source ready and all.
* Source is ready (confirmed by dougt)
* QA is a go (AaronMT in IRC says "I'd say go for it based on our testing")
* nightly.mozilla.org will be updated in the morning by webdev

This is a go, let's do the cutover.
(I'll send to r-d as well)
Comment on attachment 575284 [details] [diff] [review]
fennec nightly -> birch

Checking in config-dist.php;
/cvsroot/mozilla/webtools/aus/xml/inc/config-dist.php,v  <--  config-dist.php
new revision: 1.174; previous revision: 1.173

$ cvs tag AUS2_PRODUCTION config-dist.php
W config-dist.php : AUS2_PRODUCTION already exists on version 1.173 : NOT MOVING tag to version 1.174
$ cvs tag -F AUS2_PRODUCTION config-dist.php
T config-dist.php
Attachment #575284 - Flags: checked-in+
Depends on: 704730
The update path switched at ~ 21:15 Pacific.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: