Closed Bug 703377 Opened 10 years ago Closed 8 years ago

Remove now-unused locale pref-override functionality

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 23

People

(Reporter: Gavin, Assigned: Gavin)

Details

Attachments

(1 file, 1 obsolete file)

A long time ago in bug 364297 I added the ability to maintain previous default prefs for existing users, so that we could switch the default home page for new users without affecting existing users. We only made use of this on the 2.0 upgrade (in fact we had to get rid of the files immediately to avoid breaking people in 2.0.0.3, bug 380429), and haven't used it since (AFAIK). We should rip out the code to simplify things (and avoid an extra stat() on upgrade startups :).
Attached patch patch (obsolete) — Splinter Review
All of this code basically only kicked in if we shipped an existing-profile-defaults.js file, and we haven't done that since bug 380429.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #575285 - Flags: review?(dolske)
Attachment #575285 - Flags: review?(dolske) → review+
Is this patch landable? (I mean, if I unbitrot it)
It was on top of bug 699573's patch in my queue, and I never got around to addressing the issues with that patch. If you want to remove that dependency and un-bitrot this patch, that'd be great!
Attachment #575285 - Attachment is obsolete: true
https://hg.mozilla.org/integration/mozilla-inbound/rev/a99ad1b3fc24
Flags: in-testsuite-
Target Milestone: --- → Firefox 23
https://hg.mozilla.org/mozilla-central/rev/a99ad1b3fc24
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.