703405 - Support resizable <panel>s

Status: NEW

(Core :: XUL, defect)

Description

[Mook (work)]

It would be nice to be able to create <panel>s that are resizable; on Windows, this would be roughly equivalent to having WS_THICKFRAME / WS_SIZEBOX on the panel hwnd.  (Hacking something up as a test says this doesn't work - the panel keeps trying to animate towards the size it wants to have.)

I see that the devtools inspector panel thing currently sticks a <resizer> below the vertical scrollbar.  Having this means being able to resize via any window edge.

Comment 1

[Mook (work)]

Attachment: support resizable panels on win32/linux (against 7.0)

This patch _mostly_ works, with the follow caveats:
 - This does not support OSX; resizable panels don't make sense there, having a
   <resizer> instead fits the platform UI better.  (Presumably whoever did the
   Firefox devtools inspector is a Mac user; it does this.)
 - On Windows, resizing the panel has... issues.
    - Resizing the left/right edges does not resize the contents; newly exposed
      areas draw black.
    - Resizing the topleft/topright/bottomleft corners cause weird jumps; as
      the panel is resized, the size changes but position doesn't.  After
      releasing the mouse the panel snaps to where it should be.
 - The patch is against Gecko 7.0, which is the branch I'm working on.  Might
   need some adaptation for trunk.
 - Probably needs lots more testing.

Comment 2

[Mook (work)]

Attachment: xul file for testing

Attaching a XUL file to test this.  Not sure how to roll this into an automated test... it will need to involve synthesizing an OS-level mouse drag a few pixels outside the panel's screen position.

Comment 3

[Mook (work)]

Attachment: win32/linux support, rebased to trunk

Rebased to trunk.  If possible, pointers for the following would be appreciated:
 - tips on testing.  (which suite, etc.)
 - any ideas about why resizing is odd on windows (see comment 1).

Comment 4

[[e-mail]]

Comment on attachment 576322 [details] [diff] [review]
win32/linux support, rebased to trunk

>+        widgetData.mBorderStyle =
>+          static_cast<enum nsBorderStyle>(widgetData.mBorderStyle | eBorderStyle_resizeh);
I don't see any change in the border, and my breakpoint here wasn't hit.

>+      if (mBorderStyle != eBorderStyle_default)
Shouldn't you test if (mBorderStyle & eBorderStyle_resizeh)?

Comment 5

[Mook (work)]

Attachment: with the right check in nsWindow.cpp

(refreshed to trunk again; sorry for the delay)

(In reply to [e-mail] from comment #4)
> Comment on attachment 576322 [details] [diff] [review] [diff] [details] [review]
> win32/linux support, rebased to trunk
> 
> >+        widgetData.mBorderStyle =
> >+          static_cast<enum nsBorderStyle>(widgetData.mBorderStyle | eBorderStyle_resizeh);
> I don't see any change in the border, and my breakpoint here wasn't hit.

Odd, I do (using attachment 576317 [details] in https://addons.mozilla.org/en-US/firefox/addon/extension-developer/ ).  The breakpoint was hit, for me :( (Win7/WoW64; Ubuntu 11.10 with default-ish things, x64.)  Tried Aero-with-glass, themes-without-glass, and classic.  (The most notable effect was that it got silly double borders in class mode - once for the window, and once for the panel.)

> 
> >+      if (mBorderStyle != eBorderStyle_default)
> Shouldn't you test if (mBorderStyle & eBorderStyle_resizeh)?
Yes, I should (that is, it needs both parts); fixed.

Comment 6

[[e-mail]]

Comment on attachment 577792 [details] [diff] [review]
with the right check in nsWindow.cpp

I see the aforementioned behaviour on Windows (except I don't have acceleration, so I just get lack-of-paint artefacts instead of black), but I don't know why.

Comment 7

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

Reviving this.  

Looking at the most recent 'nit-list' at http://www.reddit.com/r/IAmA/comments/19x7up/we_are_the_firefox_user_experience_team_this_is/c8sshgy , it would decently easy to solve the "bookmark entry box is really small" sort of issues if arrow panels were resizable on the two corners away from the arrow.

in:

   ---------^---
   |            |
   ------------- 


lower right and could / should be draggable.  

I have been trying to recreate a sensible effect there using `resizers` and having trouble.  

(code at:  "editBookmarkPanel" in `browser.xul` at http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#130)