Closed Bug 703411 Opened 12 years ago Closed 12 years ago

GCC 4.6 build warning: "gfxUserFontSet.cpp:582:16: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]"

Categories

(Core :: Layout: Text and Fonts, defect)

Product:
Core
Component:
Layout: Text and Fonts
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla11

People

(Reporter: dholbert, Assigned: jfkthame)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

patch, remove obsolete variable
871 bytes, patch
jtd
: review+
Details | Diff | Splinter Review 
Filing bug for this GCC 4.6 build warning:
{
gfx/thebes/gfxUserFontSet.cpp: In member function ‘bool gfxUserFontSet::OnLoadComplete(gfxProxyFontEntry*, const PRUint8*, PRUint32, nsresult)’:
gfx/thebes/gfxUserFontSet.cpp:582:16: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]
}

This warning seems to have been introduced by bug 499292, which removed the last usage of this variable:
http://hg.mozilla.org/mozilla-central/rev/7698f12bbe7d#l4.86
OS: Linux → All
Hardware: x86_64 → All
We no longer care about the return value here, so we can just discard it and remove the variable.
Assignee: nobody → jfkthame
Attachment #575307 - Flags: review?(jdaggett)
Attachment #575307 - Flags: review?(jdaggett) → review+
https://hg.mozilla.org/mozilla-central/rev/909ff89ee487
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.