GCC 4.6 build warning: "gfxUserFontSet.cpp:582:16: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]"

RESOLVED FIXED in mozilla11

Status

()

Core
Layout: Text
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: jfkthame)

Tracking

(Blocks: 1 bug)

Trunk
mozilla11
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Filing bug for this GCC 4.6 build warning:
{
gfx/thebes/gfxUserFontSet.cpp: In member function ‘bool gfxUserFontSet::OnLoadComplete(gfxProxyFontEntry*, const PRUint8*, PRUint32, nsresult)’:
gfx/thebes/gfxUserFontSet.cpp:582:16: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]
}

This warning seems to have been introduced by bug 499292, which removed the last usage of this variable:
http://hg.mozilla.org/mozilla-central/rev/7698f12bbe7d#l4.86
OS: Linux → All
Hardware: x86_64 → All
(Assignee)

Comment 1

6 years ago
Created attachment 575307 [details] [diff] [review]
patch, remove obsolete variable

We no longer care about the return value here, so we can just discard it and remove the variable.
Assignee: nobody → jfkthame
Attachment #575307 - Flags: review?(jdaggett)

Updated

6 years ago
Attachment #575307 - Flags: review?(jdaggett) → review+
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/909ff89ee487
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/909ff89ee487
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.