Last Comment Bug 703411 - GCC 4.6 build warning: "gfxUserFontSet.cpp:582:16: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]"
: GCC 4.6 build warning: "gfxUserFontSet.cpp:582:16: warning: variable ‘status’...
Product: Core
Classification: Components
Component: Layout: Text (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla11
Assigned To: Jonathan Kew (:jfkthame)
Depends on:
Blocks: buildwarning 499292
  Show dependency treegraph
Reported: 2011-11-17 15:07 PST by Daniel Holbert [:dholbert] (vacation, returning 2/27)
Modified: 2011-11-21 09:07 PST (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch, remove obsolete variable (871 bytes, patch)
2011-11-17 15:17 PST, Jonathan Kew (:jfkthame)
jd.bugzilla: review+
Details | Diff | Splinter Review

Description User image Daniel Holbert [:dholbert] (vacation, returning 2/27) 2011-11-17 15:07:30 PST
Filing bug for this GCC 4.6 build warning:
gfx/thebes/gfxUserFontSet.cpp: In member function ‘bool gfxUserFontSet::OnLoadComplete(gfxProxyFontEntry*, const PRUint8*, PRUint32, nsresult)’:
gfx/thebes/gfxUserFontSet.cpp:582:16: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]

This warning seems to have been introduced by bug 499292, which removed the last usage of this variable:
Comment 1 User image Jonathan Kew (:jfkthame) 2011-11-17 15:17:47 PST
Created attachment 575307 [details] [diff] [review]
patch, remove obsolete variable

We no longer care about the return value here, so we can just discard it and remove the variable.
Comment 3 User image Matt Brubeck (:mbrubeck) 2011-11-21 09:07:47 PST

Note You need to log in before you can comment on or make changes to this bug.