70344 - Charset Menu: Arabic, Hebrew menu items should move to "Middle Eastern" section

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[nhottanscp]

In the trunk build, there are new menu items for Arabic and Hebrew.
They should move under "Middle Eastern" section.

Comment 1

[nhottanscp]

Attachment: A screen shot of the current charset menu, Arabic and Hebrew items are not propery located.

Comment 2

[Erik van der Poel]

Over to bidi team...

Comment 3

[Andreas Becker]

adding keyword intl.

Comment 4

[Frank Tang]

Attachment: patch to fix this issue.

Comment 5

[timeless]

r=timeless

Comment 6

[Mike Kaply [:mkaply]]

*** Bug 75477 has been marked as a duplicate of this bug. ***

Comment 7

[Erik van der Poel]

Hi Mike, please take a look at bug 74741, submitted by Maha (IBM Egypt):

  http://bugzilla.mozilla.org/show_bug.cgi?id=74741

Comment 8

[Jaime Rodriguez, Jr.]

Mike - Please accept this one as nsbeta1 and assigned a milestone of M0.9.1

Comment 9

[Mike Kaply [:mkaply]]

Attachment: Don't include hidden menuitems

Comment 10

[kill this account]

r=[e-mail]

Comment 11

[Mike Kaply [:mkaply]]

erik, can i get an sr on this one?

Comment 12

[Erik van der Poel]

sr=[e-mail]

Comment 13

[Mike Kaply [:mkaply]]

Fix checked in

Comment 14

[Yuying Long]

I still see Arabid and Hebrew charset menu items have not been moved to "Middle
Eastern" section on 05-01 trunk build?

Comment 15

[Yuying Long]

I'm re-open this bug at this point.

Comment 16

[Mike Kaply [:mkaply]]

Are you refering to the x-mac-charsets?

This is a completely different issue.

These charsets are missing names, and there are more than just arabic and 
hebrew ones.

I chose not to move them to the menu so people wouldn't forget they need to be 
fixed

Comment 17

[bobj]

If this is a different issue, let's close this and open a new bug.

Comment 18

[bobj]

Trunk build 2001050104 on US Win95
I see the problem in today's build (yesterday's build crashed on launch).

Under Middle Eastern, I only see Visual Hebrew.

Under More, I see the {Arabic,Hebrew} for {IBM, ISO, Windows}.

We probably should file a bug about the Mac ones as well.

Comment 19

[bobj]

I checked navigator.properties in my just installed chrome\en-US.jar.
And the change is not there:
   intl.charsetmenu.browser.more5=iso-8859-8

Maybe this is a build issue because I see the change in
  
http://lxr.mozilla.org/seamonkey/source/xpfe/browser/resources/locale/en-US/navi
gator.properties

Comment 20

[Mike Kaply [:mkaply]]

I built clean and they are in my Middle Eastern menus.

Maybe there is a dependency issue with navigator.properties?

Comment 21

[nhottanscp]

There is a commercial version of navigator.js, let me apply the patch and check in.

Comment 22

[bobj]

Ugh!  Keeping this info in 2 places is just asking for trouble.
Can this info be moved to a single place in the mozilla tree.

Comment 23

[nhottanscp]

I agree, filed as bug 78552.

Comment 24

[nhottanscp]

checked in the commercial change

Comment 25

[Yuying Long]

Verified on 05-11 trunk build.