Kill REPORT_BUILD; kill it dead

RESOLVED FIXED in mozilla11

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla11
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Builds are too verbose.  I build with "make -s --no-print-directory" and yet the name of every file that is compiled still gets printed like this:

 [...]
 jsarray.cpp
 jsatom.cpp
 jsbool.cpp
 jscntxt.cpp
 jsclone.cpp
 jscompartment.cpp
 [...]

This is due to REPORT_BUILD, the commit log for which was this:

  3.181 <jim_nance@yahoo.com> 2000-02-24 19:55
  Adding commands to print out the file getting built. This increases the usefulness of make -s

That's right, it took non-trivial effort to produce that spew.  I guess ol' Jim Nance wanted something between "silence" and "great big compiler invocations".  Sorry, Jim;  silence is golden.

Patch coming in a bit.  If this breaks something about the build I'm gonna cry.
(Assignee)

Comment 1

6 years ago
Created attachment 575354 [details] [diff] [review]
diff

This patch reduces the number of lines of output during a clobber debug build on my Linux64 box from 12687 to 7114.
Assignee: nobody → nnethercote
Status: NEW → ASSIGNED
(Assignee)

Updated

6 years ago
Attachment #575354 - Flags: review?(ted.mielczarek)
Comment on attachment 575354 [details] [diff] [review]
diff

Review of attachment 575354 [details] [diff] [review]:
-----------------------------------------------------------------

Fine with me, I never use "make -s", and if you are using it it seems like you'd want less output.
Attachment #575354 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9838cc0b62ee

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/9838cc0b62ee
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11

Updated

6 years ago
Depends on: 705332
Is there a way to get the names of compiled files without all the trash output that 'make' otherwise generates?  I really like(d) the output from make -s, since I could tell at a glance where in the build process a given directory was.  I often have several builds going on at once, or a build and something else, and this clean output makes triage easier and more efficient than if there is no output at all.

Comment 6

6 years ago
If we were using PyMake as the official build tool, we could hook into its API and build rich reporting not otherwise possible with GNU make. I have some work around this in bug 683438. It just needs to be hooked up to the build system.
I agree with bhackett, and am bummed about this. The spew wasn't overwhelming (the way normal spew is), and without it there's no way to tell how far along a build is. It's also nice to know what had to be rebuilt when changing headers and IDL and the like.

Ted, how would you feel about putting this back in and making the 'echo' configurable?
(In reply to Bobby Holley (:bholley) from comment #7)
See bug 705332 in this bug's dependencies.
You need to log in before you can comment on or make changes to this bug.