nsIJSInspector throws NS_ERROR_XPC_BAD_IID errors in debugger unit tests

RESOLVED FIXED

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: past, Assigned: past)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Though they work fine for me locally, the debugger xpcshell tests fail in the try run at:

https://tbpl.mozilla.org/?tree=Try&rev=425c360240ca

The error is:

TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | [Exception... "Component returned failure code: 0x80570018 (NS_ERROR_XPC_BAD_IID) [nsIJSCID.getService]"  nsresult: "0x80570018 (NS_ERROR_XPC_BAD_IID)"  location: "JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/devtools/debugger/tests/unit/test_getyoungestframe.js :: run_test :: line 4"  data: no]

The browser tests fail as well, due to the same cause.
Assignee: nobody → past
Status: NEW → ASSIGNED
Created attachment 575458 [details] [diff] [review]
Fix

As explained to me by bsmedberg, this went undetected because we always ran the binary from obj-ff-dbg/dist/ightly.app, not from the result of 'make package'.

Try run: https://tbpl.mozilla.org/?tree=Try&rev=202c0d9b0cdb
Attachment #575458 - Flags: review?(dcamp)

Updated

6 years ago
Attachment #575458 - Flags: review?(dcamp) → review+
https://hg.mozilla.org/users/dcamp_campd.org/remote-debug/rev/f7a32ec4b7e8
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.