7036 - [GTK Themes] Push buttons do not show properly

Status: VERIFIED FIXED

(Core :: Layout, enhancement, P3)

Description

[Daniel Roberts]

Here, on Red Hat Linux 6.0, using a CVS build from 5/24/1999, it seems that
oftentimes the push buttons do not render properly, particularly when using
certain GTK themes.  I am attaching a screenshot of how the buttons render here,
using the E-Mac GTK theme, and another screenshot showing ideally how buttons
like this *should* look.

Comment 1

[Daniel Roberts]

Attachment: This screenshot shows a sample of buttons that render incorrectly (using a Macintosh-like GTK theme).

Comment 2

[Daniel Roberts]

Attachment: Here is a simple screenshot from a dialog box in The GIMP, showing how E-Mac GTK buttons *should* render.

Comment 3

[Daniel Roberts]

BTW, this seems to happen quite often (I would estimate at least 50% of the
time).  It only seems to happen with certain GTK themes, like E-Mac (found on
gtk.themes.org), but nonetheless, this is a deviation from the behavior I would
expect from Mozilla, since no other GTK program I've ever tried does this to me.

Comment 4

[Kevin McCluskey (gone)]

Are they using gfx widgets, instead of native widgets for apprunner on Linux?
The gfx widgets will not honor the theme settings.
Ramiro, I'm re-assigning to you assumming they are using native widgets.

Comment 5

[stuartp]

since i'm doing the widget stuff, i'll steal this one from you ramiro.

Comment 6

[stuartp]

What version GTK are you using?

Comment 7

[Daniel Roberts]

Oh, I'm sorry...  GTK 1.2.1, as packaged with Red Hat 6.0.  I am also using
GNOME.  (gnome-libs 1.0.8, core 1.0.5).

Shall I try upgrading to GTK 1.2.3?

Comment 8

[Stuart Parmenter]

please see if this is still happening.  moving gtk theme issues to M15

Comment 9

[Daniel Roberts]

I have been trying to stay away from Pixmap themes lately, due to the crashes
they cause (which is even more serious, as that prevents me from using Mozilla,
whereas this bug wont), and I haven't seen this problem lately with other
(non-Pixmap) themes.

I suggest that we mark all of the GTK+ Pixmap Theme-related bugs as WONTFIX,
since they are not Mozilla bugs (and probably not easy to workaround), and
mention in the release notes that people need to stay away from Pixmap themes
until such time as the GTK+-engines people fix this bug.  After all, this is
really their problem.  This bug in particular should be a WONTFIX in my opinion,
because the crashing problem is much more of a showstopper even than this is.
Everyone agree?

Comment 10

[Stuart Parmenter]

no, leave them alone.  i'll find a fix for these later.  thats why they are
marked M15

Comment 11

[Stuart Parmenter]

we use gfx buttons now so this was fixed by those

Comment 12

[Chris Petersen]

Marking verified fixed in the Oct 1 build.