Give developers ability to build PSM 2.0 on Win32

VERIFIED FIXED

Status

SeaMonkey
Build Config
VERIFIED FIXED
17 years ago
13 years ago

People

(Reporter: Javier Delgadillo, Assigned: Javier Delgadillo)

Tracking

Trunk
x86
Windows NT

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Assignee)

Description

17 years ago
We want to give windows developers the ability to test drive PSM 2.0

With the attached patch, they will be able to do so when the environment
variable BUILD_PSM2 is set.
(Assignee)

Comment 1

17 years ago
Created attachment 26306 [details] [diff] [review]
Patch to enable PSM 2.0 for win32 builds
(Assignee)

Comment 2

17 years ago
Created attachment 26308 [details] [diff] [review]
Updated patch, first one had a typo.

Comment 3

17 years ago
shouldn't the use of NSS 3.2 be triggered by BUILD_PSM2 as well? AFAIK, we're 
not moving to NSS 3.2 just yet, are we?
(Assignee)

Comment 4

17 years ago
Well, we need NSS 3.2 so that profile switching can work correctly.  We don't
absolutely need it now, but will eventually.  We've been developing PSM 2.0
against NSS 3.2, so I can't comment on the stability of PSM 2.0 with NSS 3.11
(NSS_CLIENT_TAG version) or PSM 1.x with NSS 3.2

Maybe we leave NSS_CLIENT_TAG for now and switch it once we convert to PSM 2.0
by default.

Comment 5

17 years ago
I don't think changing the NSS tag falls into the scope of this bug... having it 
set optionally makes perfect sense, but until more testing has been done with 
the mozilla trunk + PSM 1.3 + NSS 3.2, i don't think it's reasonable to flip 
that switch for everyone.
(Assignee)

Comment 6

17 years ago
Created attachment 26410 [details] [diff] [review]
Updated patch which keeps NSS_CLIENT_TAG as the version for NSS

Comment 7

17 years ago
ok, so if i have this right, the security/manager trunk is where psm2 lives?

I'll write up a patch that does what i think you really want (pulling NSS 3.2 if 
you're building psm2).

Updated

17 years ago
Summary: Give developpers ability to build PSM 2.0 on Win32 → Give developers ability to build PSM 2.0 on Win32

Comment 8

17 years ago
Created attachment 26569 [details] [diff] [review]
move the check for BUILD_PSM2 into security/makefile.win

Comment 9

17 years ago
my patch requires that you have both BUILD_PSM and BUILD_PSM2 set, and fixes a 
bogus build_psm target in client.mak

Comment 10

17 years ago
sorry, a better patch for mozilla/makefile.win is:

Index: makefile.win
===================================================================
RCS file: /cvsroot/mozilla/makefile.win,v
retrieving revision 3.96
diff -u -r3.96 makefile.win
--- makefile.win        2001/02/22 09:17:32     3.96
+++ makefile.win        2001/03/01 23:43:38
@@ -58,7 +58,7 @@
   modules\mpfilelocprovider    \
   modules\zlib                 \
   netwerk                      \
-!if defined(BUILD_PSM)
+!if defined(BUILD_PSM) || defined(BUILD_PSM2)
   security                     \
 !endif
   widget\timer                 \
(Assignee)

Comment 11

17 years ago
Latest patch with the "better" patch for client.mak gets r=javi
(Assignee)

Comment 12

17 years ago
leaf:

patch looks good to me, can I go ahead and check it in?

Comment 13

17 years ago
so, i wrote it, you r= it, cls should sr= it.

Comment 14

17 years ago
sr=cls
(Assignee)

Comment 15

17 years ago
Patch checked in.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 16

17 years ago
verified.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.