Last Comment Bug 703715 - Add Telemetry probes for sync XHR
: Add Telemetry probes for sync XHR
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: x86_64 All
: -- normal (vote)
: ---
Assigned To: Olli Pettay [:smaug] (high review load, please consider other reviewers)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-18 12:38 PST by Olli Pettay [:smaug] (high review load, please consider other reviewers)
Modified: 2011-11-19 11:26 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.42 KB, patch)
2011-11-18 13:35 PST, Olli Pettay [:smaug] (high review load, please consider other reviewers)
jonas: review+
taras.mozilla: review+
Details | Diff | Review

Description Olli Pettay [:smaug] (high review load, please consider other reviewers) 2011-11-18 12:38:48 PST
Sync XHR in Window context is terrible, and if just possible we should get rid of it.
(it may takes years to achieve that)
Comment 1 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2011-11-18 13:35:34 PST
Created attachment 575543 [details] [diff] [review]
patch
Comment 2 Jonas Sicking (:sicking) PTO Until July 5th 2011-11-18 13:40:51 PST
Comment on attachment 575543 [details] [diff] [review]
patch

Assuming this will let us see how man async as well as sync requests are made.

It'd be awesome if we could get a count on how many sites out there use sync XHR, but I don't see a way of doing that without effectively sending the domain name of the site to us, which would be terrible privacy.
Comment 3 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2011-11-18 13:44:54 PST
This counts all the open() calls, and either increases the async bar (0), or sync bar(1), so yes
it is easy to check how many XHR open calls there has been, and how many of those have been sync.
Comment 4 (dormant account) 2011-11-18 14:11:19 PST
Comment on attachment 575543 [details] [diff] [review]
patch

dont need empty lines in TelemetryHistograms.h
Comment 5 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2011-11-19 11:26:07 PST
https://hg.mozilla.org/mozilla-central/rev/714cd1b8ad93
https://hg.mozilla.org/mozilla-central/rev/7dd46087e678

Note You need to log in before you can comment on or make changes to this bug.