Add Telemetry probes for sync XHR

RESOLVED FIXED

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

2.42 KB, patch
sicking
: review+
(dormant account)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
Sync XHR in Window context is terrible, and if just possible we should get rid of it.
(it may takes years to achieve that)
(Assignee)

Updated

6 years ago
Assignee: nobody → bugs
(Assignee)

Comment 1

6 years ago
Created attachment 575543 [details] [diff] [review]
patch
Attachment #575543 - Flags: review?(tglek)
Attachment #575543 - Flags: review?(jonas)
Comment on attachment 575543 [details] [diff] [review]
patch

Assuming this will let us see how man async as well as sync requests are made.

It'd be awesome if we could get a count on how many sites out there use sync XHR, but I don't see a way of doing that without effectively sending the domain name of the site to us, which would be terrible privacy.
Attachment #575543 - Flags: review?(jonas) → review+
(Assignee)

Comment 3

6 years ago
This counts all the open() calls, and either increases the async bar (0), or sync bar(1), so yes
it is easy to check how many XHR open calls there has been, and how many of those have been sync.

Comment 4

6 years ago
Comment on attachment 575543 [details] [diff] [review]
patch

dont need empty lines in TelemetryHistograms.h
Attachment #575543 - Flags: review?(tglek) → review+
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/714cd1b8ad93
https://hg.mozilla.org/mozilla-central/rev/7dd46087e678
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.