Closed Bug 703715 Opened 12 years ago Closed 12 years ago

Add Telemetry probes for sync XHR

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86_64
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(1 file)

patch
2.42 KB, patch
sicking
: review+
taras.mozilla
: review+
Details | Diff | Splinter Review 
Sync XHR in Window context is terrible, and if just possible we should get rid of it.
(it may takes years to achieve that)
Assignee: nobody → bugs
Attached patch patch — — Splinter Review 

        Attachment #575543 -
        Flags: review?(tglek)

        Attachment #575543 -
        Flags: review?(jonas)

    
    

    
  
Comment on attachment 575543 [details] [diff] [review]
patch

Assuming this will let us see how man async as well as sync requests are made.

It'd be awesome if we could get a count on how many sites out there use sync XHR, but I don't see a way of doing that without effectively sending the domain name of the site to us, which would be terrible privacy.

        Attachment #575543 -
        Flags: review?(jonas) → review+

    
    

    
  
This counts all the open() calls, and either increases the async bar (0), or sync bar(1), so yes
it is easy to check how many XHR open calls there has been, and how many of those have been sync.

    
    

    
  
Comment on attachment 575543 [details] [diff] [review]
patch

dont need empty lines in TelemetryHistograms.h

        Attachment #575543 -
        Flags: review?(tglek) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.