703732 - Show compatibility error if an add-on uses isSameNode

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect, P2)

Description

[Jorge Villalobos [:jorgev] (he/him)]

As explained in bug 687400, the DOM function isSameNode is being removed (probably). We need to flag all instances of these function calls and show an error.

This is a compatibility error, so the add-on should not be upgraded in this case.

Message:

The "isSameNode" function has been removed. You can use the == operator as an alternative. See <LINK> for more information.

Link: https://bugzilla.mozilla.org/show_bug.cgi?id=687400

Affected add-on:

https://addons.mozilla.org/en-US/firefox/addon/scrapbook/

Comment 1

[Kumar McMillan [:kumar]]

Fixed: https://github.com/mozilla/amo-validator/commit/62a91226f358eee683e741d6c17e3a4e45df2309

Pushed to zamboni: https://github.com/mozilla/zamboni/commit/6c4d24f

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

Sorry for the last-minute change, but the message is wrong. It should say === instead of ==.

Corrected message:

The "isSameNode" function has been removed. You can use the === operator as an alternative. See <LINK> for more information.

Comment 3

[Kumar McMillan [:kumar]]

Fixed https://github.com/mozilla/amo-validator/commit/60eb9218637095781c3ea13099dfccd7aeb747e4
Pushed to z: https://github.com/mozilla/zamboni/commit/a018fb5