Last Comment Bug 703843 - elfhack Makefile using order-only prerequisites, not compatible with PyMake
: elfhack Makefile using order-only prerequisites, not compatible with PyMake
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Mike Hommey [:glandium]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-19 01:23 PST by Gregory Szorc [:gps]
Modified: 2012-08-09 15:01 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Use mkdir_deps instead of order-only prerequisite in build/unix/elfhack/Makefile.in (949 bytes, patch)
2012-08-07 02:13 PDT, Mike Hommey [:glandium]
ted: review+
Details | Diff | Splinter Review

Description Gregory Szorc [:gps] 2011-11-19 01:23:05 PST
It looks there is an order-only prerequisite in elfhack's Makefile: https://mxr.mozilla.org/mozilla-central/source/build/unix/elfhack/Makefile.in#124

Unfortunately, PyMake doesn't support order-only prerequisites. The offending rule should be rewritten to not use order-only prerequisites so PyMake can parse it.
Comment 1 Mike Hommey [:glandium] 2012-08-07 02:13:21 PDT
Created attachment 649577 [details] [diff] [review]
Use mkdir_deps instead of order-only prerequisite in build/unix/elfhack/Makefile.in
Comment 3 Ryan VanderMeulen [:RyanVM] 2012-08-09 15:01:20 PDT
https://hg.mozilla.org/mozilla-central/rev/2e809e2113ad

Note You need to log in before you can comment on or make changes to this bug.