Remove redundant |ifneq (mobile,$(MOZ_BUILD_APP))| from makefiles in browser/*

RESOLVED FIXED in mozilla11

Status

defect
--
trivial
RESOLVED FIXED
8 years ago
7 months ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Trunk
mozilla11
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

There are a few instances of |ifneq (mobile,$(MOZ_BUILD_APP))| in makefiles in browser/* which are obviously redundant. 

Two of the three instances are recent, and have been most likely copied from the third (browser/devtools/webconsole/Makefile.in), which original existed in toolkit (http://hg.mozilla.org/mozilla-central/rev/2cf6a6d0f962), where the check was obviously necessary.

http://mxr.mozilla.org/mozilla-central/search?string=mobile&find=%2Fbrowser%2F.*\.in
Posted patch Patch v1Splinter Review
Attachment #575660 - Flags: review?(ted.mielczarek)
Thanks for telling us about this, and fixing it. I'm removing bug 582596 and bug 583041 from the blocks lists because they're closed.
No longer blocks: 582596, 583041
https://hg.mozilla.org/integration/mozilla-inbound/rev/e837d33a508b
Flags: in-testsuite-
Target Milestone: --- → Firefox 11
https://hg.mozilla.org/mozilla-central/rev/e837d33a508b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 11 → mozilla11
You need to log in before you can comment on or make changes to this bug.