Remove redundant |ifneq (mobile,$(MOZ_BUILD_APP))| from makefiles in browser/*

RESOLVED FIXED in Firefox 11

Status

()

Firefox
Build Config
--
trivial
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Trunk
Firefox 11
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
There are a few instances of |ifneq (mobile,$(MOZ_BUILD_APP))| in makefiles in browser/* which are obviously redundant. 

Two of the three instances are recent, and have been most likely copied from the third (browser/devtools/webconsole/Makefile.in), which original existed in toolkit (http://hg.mozilla.org/mozilla-central/rev/2cf6a6d0f962), where the check was obviously necessary.

http://mxr.mozilla.org/mozilla-central/search?string=mobile&find=%2Fbrowser%2F.*\.in
(Assignee)

Comment 1

6 years ago
Created attachment 575660 [details] [diff] [review]
Patch v1
Attachment #575660 - Flags: review?(ted.mielczarek)
Attachment #575660 - Flags: review?(ted.mielczarek) → review+
Thanks for telling us about this, and fixing it. I'm removing bug 582596 and bug 583041 from the blocks lists because they're closed.
No longer blocks: 582596, 583041
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e837d33a508b
Flags: in-testsuite-
Target Milestone: --- → Firefox 11
https://hg.mozilla.org/mozilla-central/rev/e837d33a508b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.