Closed Bug 70391 Opened 23 years ago Closed 23 years ago

Browser crashes while mousing over to "Image Manager"

Categories

(Core :: Security, defect)

x86
Windows 98
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla0.9

People

(Reporter: pmac, Assigned: morse)

References

Details

(Keywords: crash)

Platform: Windows and Linux (2001-02-26-22-Mtrunk)

I'm not sure this is the right component, if not, please forward this bug
to the right component. Thanks!

Steps to reproduce:

1. Launch Commercial trunk build (2001-02-26-22-Mtrunk).
2. Mouse over to Tasks/Privacy and Security/Image Manager.
Note: It crashes in both modern and classic skins. Talkback report
is coming...
Keywords: nsbeta1
Talkback report:

Trigger Type:  Program Crash 

 Trigger Reason:  Access violation 

 Thread ID:   

 Call Stack:    (Signature = GKLAYOUT.DLL + 0x5d7c6 (0x6033d7c6) 177c6feb) 
     
   GKLAYOUT.DLL + 0x5d7c6 (0x6033d7c6) 
                                         
     
   GKLAYOUT.DLL + 0x5f760 (0x6033f760) 
                                         
     
   GKLAYOUT.DLL + 0x631a3 (0x603431a3) 
                                         
     
   GKLAYOUT.DLL + 0x324d8 (0x603124d8) 
                                         
     
   GKLAYOUT.DLL + 0xa4f7 (0x602ea4f7) 
                                         
     
   GKCONTENT.DLL + 0x16332 (0x601d6332) 
                                         
     
   GKLAYOUT.DLL + 0xa189 (0x602ea189) 
                                         
     
   GKCONTENT.DLL + 0x825f0 (0x602425f0) 
                                         
     
   GKCONTENT.DLL + 0xd20bf (0x602920bf) 
                                         
     
   GKCONTENT.DLL + 0xcf7c0 (0x6028f7c0) 
                                         
     
   GKLAYOUT.DLL + 0x61b06 (0x60341b06) 
                                         
     
   GKLAYOUT.DLL + 0x9055d (0x6037055d) 
                                         
     
   GKWIDGET.DLL + 0x3876 (0x60ad3876) 
                                         
     
   GKWIDGET.DLL + 0x37b7 (0x60ad37b7) 
                                         
     
   KERNEL32.DLL + 0x2317 (0xbff72317) 
                                         
     
   GKWIDGET.DLL + 0x3732 (0x60ad3732) 
                                         
     
   0x37320003 
                                         
     
   0xf676ff66 
                                         

Keywords: crash
->morse
Assignee: mstoltz → morse
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9
Mass moving most of mozilla0.9 bugs to mozilla0.8.1
Target Milestone: mozilla0.9 → mozilla0.8.1
*** Bug 71479 has been marked as a duplicate of this bug. ***
Target Milestone: mozilla0.8.1 → mozilla0.9
I'm unable to reproduce.  Also I'm a little surprised by this because it talks 
about the commercial build but the commercial build doesn't have the image 
manager (unless user knows to set the stealth pref to make image manager 
visible).  pmac, please clarify this point.
Hi Morse, Sujay also filed the bug 71479 which is a duplicated bug of this one.
Anyway, ignore launching Commercial trunk build if you think I use
the wrong word but I thought this is trunk build, isn't it?  Just launch 
Netscape, so maybe it would clear. I just verified on windows 98 with 
a recent build (2001-03-15-15-Mtrunk). and it crashes!

To able to see this, mouse over to Tasks/Privacy and Security/Image Manager.
The browser crashes! Talkback report is coming...
I'm still a little confused.  Are you talking about a Netscape (a.k.a. 
commercial) build or a Mozilla build?  The former does not have the image 
manager whereas the latter does.
Steve, yes, I'm using the build (2001-03-15-15-Mtrunk) from 
ftp://sweetlou/products/client/seamonkey/windows/32bit/x86/
and I think people might call as "commercial build". It does have
this feature "Image Manager". I will demonstrate for you if you
drop by my cubic. Sujay also filed this bug too.
OK, I pulled the build you indicated and it does exactly what you said.  What's 
worse is that image-manager is in the menu (it should not be there for the 
netscape build, only for the mozilla build).  So I'm not surprised that it's 
crashing since I have no idea what code is being accessed for a feature that is 
not supposed to be there.

I will investigate further.
OK, I see what the problem is.  This got broke when I moved all the 
cookie stuff out of the main browser code and into its own overlay.  In doing 
so, I needed to put a call to an oncreate handler in the overlay but I put it in 
the wrong place.  Specifically, I put it on a node which is the child of the 
node that the oncreate handler was hiding and that was causing the crash.

The file involved in cookieTasksOverlay.xul.  I'm currently in the process of 
reorganizing the cookie module (bug 46783) and cookieTasksOverlay.xul is one of 
the files that I'm changing in the patch for that reorg.  So I'll extend that 
patch to include the fix for this bug as well.  Then when I check in the patch 
for bug 46783, I'll be able to close out this bug report.
Fixed as part of the checkin for bug 46783 that just occured.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
*** Bug 74100 has been marked as a duplicate of this bug. ***
*** Bug 76083 has been marked as a duplicate of this bug. ***
Assigning to originator for verificiation...
->pmac@netscape.com
QA Contact: ckritzer → pmac
Since this feature "Image Manager" is no longer available under
Tasks > Privacy and Security > Image Manager. Therfore, close this bug.
Status: RESOLVED → VERIFIED
Since this feature "Image Manager" is no longer available under
Tasks > Privacy and Security > Image Manager. Therfore, close this bug.
Since this feature "Image Manager" is no longer available under
Tasks > Privacy and Security > Image Manager. Therfore, close this bug.
I guess it must be true since you said it three times.  But when did that 
happen?  On a build that I made yesterday I still see it in the task menu.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Fixed but not verified
Status: REOPENED → RESOLVED
Closed: 23 years ago23 years ago
Resolution: --- → FIXED
Steve, I did not mean to say three times, maybe accidently hit the submit
button twice. Anyway, if you confirm on today's build on windows
(2001-05-17-07-Mtrunk) and Linux 92001-05-17-08-Mtrunk), the feature 
"Image manger" is not there anymore.
Are you running mozilla or commercial?  If commercial, are you setting the pref 
that turns of image manger (it is turned off by default in commercial build)?
Steve, I'm running the commercial build though. Anyway, I go to the 
preferences setting and turn it on, and it does not crash anymore,
so for this bug, it's fixed already I think. But I'll file another bug, 
will report it soon. Marking verified on windows 98 (2001-05-17-07-Mtrunk)
and Linux (2001-05-17-08-Mtrunk). Thanks Steve!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.