Closed Bug 703920 Opened 8 years ago Closed 8 years ago

about:config: filter prefs after pressing the enter key, remove the Filter button, add a Clear button

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

References

Details

Attachments

(1 file)

In about:config, the prefs should be filtered as soon as you type in the filter box, without having to press the Filter button.

Like the XUL version did.
Filtering the prefs and especially removing the filter so that all prefs are displayed again, is expensive, it takes a couple of seconds on my phone (Galaxy S). So we shouldn't filter on keypress.

However, the enter key should activate the filter.
And we need a Clear button.
Summary: about:config: filter prefs on input, without having to press the Filter button → about:config: filter prefs after pressing the enter key, remove the Filter button, add a Clear button
Attached patch patch v1Splinter Review
I use <input type="search"> instead of "text" to display the magnifying glass on the VKB.
The onchange event is triggered when the filter box loses focus, or you press the enter key. When that happens, the VKB is closed by calling blur() on the filter box.

The Clear button is positioned under the filter box (where the current Filter button is located). That's unusual but handy since you don't need to scroll.
I tried some hackery to make it appear *inside* the filter box, but the vertical position moved with the value of the new font.size.inflation.minTwips pref; using em doesn't help.
The Clear button is disabled when the filter box is empty because of said multi-second lag when rebuilding the page.
Assignee: nobody → steffen.wilberg
Status: NEW → ASSIGNED
Attachment #577011 - Flags: review?(mark.finkle)
Attachment #577011 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/projects/birch/rev/fe5c5000bc2d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Blocks: 706272
Verified fixed on:
Fennec Nightly 13.0a1 (2012-02-09)
Device: Samsung Galaxy SII

Currently the Clear(X) button is positioned on the right side of the search box
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.