Move WebConsole style from toolkit to browser

RESOLVED FIXED in Firefox 11

Status

()

Firefox
Developer Tools: Console
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sonny, Assigned: sonny)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 11
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

Comment hidden (empty)
(Assignee)

Updated

6 years ago
Assignee: nobody → sonny.piers
(Assignee)

Updated

6 years ago
Blocks: 603001, 635359
(Assignee)

Updated

6 years ago
Blocks: 592463
No longer blocks: 603001, 635359
(Assignee)

Updated

6 years ago
Blocks: 635359
(Assignee)

Updated

6 years ago
Blocks: 603001
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

6 years ago
Created attachment 575749 [details] [diff] [review]
WIP patch v0.1

Mihai,
* I deleted the "+" and "*" from jar.mn files because I think they are unneeded, what do you think?
* I deleted aero specific stuff because I don't think they are needed too. (aero herits from winstrip right?)
* What about files name?
Attachment #575749 - Flags: feedback?(mihai.sucan)
(Assignee)

Comment 2

6 years ago
Paul, I need tests on OSX/Windows, can you please run a try build with the patch?
(Assignee)

Comment 3

6 years ago
Paul, try: -b do -e -p linux,macosx64,win32 -u mochitests -t none

Comment 4

6 years ago
https://tbpl.mozilla.org/?tree=Try&rev=751b295adf53
Comment on attachment 575749 [details] [diff] [review]
WIP patch v0.1

Review of attachment 575749 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good! As discussed on IRC, this patch needs an update for the winaero theme. The jar.mn file has two sections, one for aero. Please check and update the file as needed. Thank you!
Attachment #575749 - Flags: feedback?(mihai.sucan) → feedback+
(Assignee)

Comment 6

6 years ago
Created attachment 575976 [details] [diff] [review]
patch v0.2
(Assignee)

Comment 7

6 years ago
paul, could you run a try build with the new patch?
try: -b do -p all -u mochitests -t none
(Assignee)

Comment 8

6 years ago
Sorry I meant try: -b do -p linux,macosx64,win32 -u mochitests -t none

Comment 9

6 years ago
> Thanks for your try submission (http://hg.mozilla.org/try/pushloghtml?changeset=96b7aabe658e). It's the best!
> Watch https://tbpl.mozilla.org/?tree=Try&rev=96b7aabe658e for your results to come in
> Builds and logs will be available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/prouget@mozilla.com-96b7aabe658e
> This directory won't be created until the first builds are uploaded, so please be patient.
(Assignee)

Comment 10

6 years ago
Created attachment 575998 [details]
wrong bug!
sorry :-)
(Assignee)

Updated

6 years ago
Attachment #575998 - Flags: review?(mihai.sucan)
(Assignee)

Updated

6 years ago
Attachment #575998 - Attachment description: patch v1 → wrong bug! sorry :-)
Attachment #575998 - Attachment is obsolete: true
Attachment #575998 - Attachment is patch: false
Attachment #575998 - Flags: review?(mihai.sucan)
Comment on attachment 575976 [details] [diff] [review]
patch v0.2

>--- a/browser/themes/winstripe/jar.mn
>+++ b/browser/themes/winstripe/jar.mn

>         skin/classic/aero/browser/tabview/tabview.png                (tabview/tabview.png)
>         skin/classic/aero/browser/tabview/tabview-inverted.png       (tabview/tabview-inverted.png)
>         skin/classic/aero/browser/tabview/tabview.css                (tabview/tabview.css)
>         skin/classic/aero/browser/devtools/arrows.png                (devtools/arrows.png)
>         skin/classic/aero/browser/devtools/goto-mdn.png              (devtools/goto-mdn.png)
>         skin/classic/aero/browser/devtools/csshtmltree.css           (devtools/csshtmltree.css)
>         skin/classic/aero/browser/devtools/gcli.css                  (devtools/gcli.css)
>         skin/classic/aero/browser/devtools/toolbarbutton-close.png   (devtools/toolbarbutton-close.png)
>+        skin/classic/browser/devtools/webconsole.css                  (devtools/webconsole.css)
>+        skin/classic/browser/devtools/webconsole_networkpanel.css     (devtools/webconsole_networkpanel.css)
>+        skin/classic/browser/devtools/webconsole.png                  (devtools/webconsole.png)

This needs to be skin/classic/aero/browser/
(Assignee)

Comment 12

6 years ago
Created attachment 576684 [details] [diff] [review]
patch v1
(Assignee)

Updated

6 years ago
Attachment #575976 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Attachment #576684 - Flags: review?(mihai.sucan)
Attachment #576684 - Flags: review?(dao)
(Assignee)

Updated

6 years ago
Attachment #575749 - Attachment is obsolete: true
(Assignee)

Comment 13

6 years ago
Dao, of course, sorry.
(Assignee)

Comment 14

6 years ago
Created attachment 576690 [details] [diff] [review]
patch v1.1
(Assignee)

Updated

6 years ago
Attachment #576684 - Attachment is obsolete: true
Attachment #576684 - Flags: review?(mihai.sucan)
Attachment #576684 - Flags: review?(dao)
(Assignee)

Updated

6 years ago
Attachment #576690 - Flags: review?(mihai.sucan)
Attachment #576690 - Flags: review?(dao)
Comment on attachment 576690 [details] [diff] [review]
patch v1.1

long overdue. thanks :)
Attachment #576690 - Flags: review?(dao) → review+
Whiteboard: [land-in-fx-team]
Comment on attachment 576690 [details] [diff] [review]
patch v1.1

Review of attachment 576690 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good. Sonny, thank you very much for your contribution!

(apologies for the delay! the email with the review request got lost somehow...)
Attachment #576690 - Flags: review?(mihai.sucan) → review+
Comment on attachment 576690 [details] [diff] [review]
patch v1.1

readded the preprocessing directive to pinstripe's jar.mn file. Styles weren't applying there.
https://hg.mozilla.org/integration/fx-team/rev/ce0a05f13572
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/ce0a05f13572
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 11
You need to log in before you can comment on or make changes to this bug.