Last Comment Bug 703938 - Move WebConsole style from toolkit to browser
: Move WebConsole style from toolkit to browser
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 11
Assigned To: Sonny Piers [:sonny]
:
Mentors:
Depends on:
Blocks: consolecleanup 603001 635359
  Show dependency treegraph
 
Reported: 2011-11-19 18:03 PST by Sonny Piers [:sonny]
Modified: 2011-11-29 22:08 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
WIP patch v0.1 (22.91 KB, patch)
2011-11-20 07:51 PST, Sonny Piers [:sonny]
mihai.sucan: feedback+
Details | Diff | Review
patch v0.2 (25.03 KB, patch)
2011-11-21 14:29 PST, Sonny Piers [:sonny]
no flags Details | Diff | Review
wrong bug! sorry :-) (6.01 KB, text/plain)
2011-11-21 15:24 PST, Sonny Piers [:sonny]
no flags Details
patch v1 (25.05 KB, patch)
2011-11-23 23:24 PST, Sonny Piers [:sonny]
no flags Details | Diff | Review
patch v1.1 (27.17 KB, patch)
2011-11-24 00:19 PST, Sonny Piers [:sonny]
dao+bmo: review+
mihai.sucan: review+
Details | Diff | Review

Description Sonny Piers [:sonny] 2011-11-19 18:03:30 PST

    
Comment 1 Sonny Piers [:sonny] 2011-11-20 07:51:31 PST
Created attachment 575749 [details] [diff] [review]
WIP patch v0.1

Mihai,
* I deleted the "+" and "*" from jar.mn files because I think they are unneeded, what do you think?
* I deleted aero specific stuff because I don't think they are needed too. (aero herits from winstrip right?)
* What about files name?
Comment 2 Sonny Piers [:sonny] 2011-11-20 07:59:23 PST
Paul, I need tests on OSX/Windows, can you please run a try build with the patch?
Comment 3 Sonny Piers [:sonny] 2011-11-20 08:01:44 PST
Paul, try: -b do -e -p linux,macosx64,win32 -u mochitests -t none
Comment 4 Paul Rouget [:paul] 2011-11-20 08:12:09 PST
https://tbpl.mozilla.org/?tree=Try&rev=751b295adf53
Comment 5 Mihai Sucan [:msucan] 2011-11-21 06:06:22 PST
Comment on attachment 575749 [details] [diff] [review]
WIP patch v0.1

Review of attachment 575749 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good! As discussed on IRC, this patch needs an update for the winaero theme. The jar.mn file has two sections, one for aero. Please check and update the file as needed. Thank you!
Comment 6 Sonny Piers [:sonny] 2011-11-21 14:29:07 PST
Created attachment 575976 [details] [diff] [review]
patch v0.2
Comment 7 Sonny Piers [:sonny] 2011-11-21 14:32:01 PST
paul, could you run a try build with the new patch?
try: -b do -p all -u mochitests -t none
Comment 8 Sonny Piers [:sonny] 2011-11-21 14:41:23 PST
Sorry I meant try: -b do -p linux,macosx64,win32 -u mochitests -t none
Comment 9 Paul Rouget [:paul] 2011-11-21 15:00:04 PST
> Thanks for your try submission (http://hg.mozilla.org/try/pushloghtml?changeset=96b7aabe658e). It's the best!
> Watch https://tbpl.mozilla.org/?tree=Try&rev=96b7aabe658e for your results to come in
> Builds and logs will be available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/prouget@mozilla.com-96b7aabe658e
> This directory won't be created until the first builds are uploaded, so please be patient.
Comment 10 Sonny Piers [:sonny] 2011-11-21 15:24:57 PST
Created attachment 575998 [details]
wrong bug!
sorry :-)
Comment 11 Dão Gottwald [:dao] 2011-11-22 01:26:15 PST
Comment on attachment 575976 [details] [diff] [review]
patch v0.2

>--- a/browser/themes/winstripe/jar.mn
>+++ b/browser/themes/winstripe/jar.mn

>         skin/classic/aero/browser/tabview/tabview.png                (tabview/tabview.png)
>         skin/classic/aero/browser/tabview/tabview-inverted.png       (tabview/tabview-inverted.png)
>         skin/classic/aero/browser/tabview/tabview.css                (tabview/tabview.css)
>         skin/classic/aero/browser/devtools/arrows.png                (devtools/arrows.png)
>         skin/classic/aero/browser/devtools/goto-mdn.png              (devtools/goto-mdn.png)
>         skin/classic/aero/browser/devtools/csshtmltree.css           (devtools/csshtmltree.css)
>         skin/classic/aero/browser/devtools/gcli.css                  (devtools/gcli.css)
>         skin/classic/aero/browser/devtools/toolbarbutton-close.png   (devtools/toolbarbutton-close.png)
>+        skin/classic/browser/devtools/webconsole.css                  (devtools/webconsole.css)
>+        skin/classic/browser/devtools/webconsole_networkpanel.css     (devtools/webconsole_networkpanel.css)
>+        skin/classic/browser/devtools/webconsole.png                  (devtools/webconsole.png)

This needs to be skin/classic/aero/browser/
Comment 12 Sonny Piers [:sonny] 2011-11-23 23:24:55 PST
Created attachment 576684 [details] [diff] [review]
patch v1
Comment 13 Sonny Piers [:sonny] 2011-11-23 23:27:44 PST
Dao, of course, sorry.
Comment 14 Sonny Piers [:sonny] 2011-11-24 00:19:28 PST
Created attachment 576690 [details] [diff] [review]
patch v1.1
Comment 15 Dão Gottwald [:dao] 2011-11-24 02:05:50 PST
Comment on attachment 576690 [details] [diff] [review]
patch v1.1

long overdue. thanks :)
Comment 16 Mihai Sucan [:msucan] 2011-11-28 11:43:31 PST
Comment on attachment 576690 [details] [diff] [review]
patch v1.1

Review of attachment 576690 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good. Sonny, thank you very much for your contribution!

(apologies for the delay! the email with the review request got lost somehow...)
Comment 17 Rob Campbell [:rc] (:robcee) 2011-11-29 10:51:40 PST
Comment on attachment 576690 [details] [diff] [review]
patch v1.1

readded the preprocessing directive to pinstripe's jar.mn file. Styles weren't applying there.
Comment 18 Rob Campbell [:rc] (:robcee) 2011-11-29 11:14:45 PST
https://hg.mozilla.org/integration/fx-team/rev/ce0a05f13572
Comment 19 Tim Taubert [:ttaubert] 2011-11-29 22:08:05 PST
https://hg.mozilla.org/mozilla-central/rev/ce0a05f13572

Note You need to log in before you can comment on or make changes to this bug.