nsStyleLinkElement::ParseLinkTypes should check for HTML5 white space

RESOLVED FIXED in mozilla11

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: drexler)

Tracking

Trunk
mozilla11
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good_first_bug][mentor=Ms2ger])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
See <http://www.whatwg.org/html/#space-character> / nsContentUtils::IsHTMLWhitespace.
(Reporter)

Updated

6 years ago
Whiteboard: [good_first_bug][mentor=Ms2ger]
(Assignee)

Comment 1

6 years ago
Created attachment 575932 [details] [diff] [review]
Check for HTML5 whitespace

Changed checks for whitespace by IsAsciiSpace to IsHTMLWhitespace.
Attachment #575932 - Flags: review?(Ms2ger)
(Reporter)

Comment 2

6 years ago
Comment on attachment 575932 [details] [diff] [review]
Check for HTML5 whitespace

LGTM, but I can't actually review this. Boris?
Attachment #575932 - Flags: review?(bzbarsky)
Attachment #575932 - Flags: review?(Ms2ger)
Attachment #575932 - Flags: feedback+
Comment on attachment 575932 [details] [diff] [review]
Check for HTML5 whitespace

The commit message should be closer to:

  Bug 704013.  nsStyleLinkElement::ParseLinkTypes should use HTML5 definition of "whitespace".

r=me with that adjusted.  Thanks for the patch!

Ms2ger, I trust you'll get this landed?
Attachment #575932 - Flags: review?(bzbarsky) → review+
(Reporter)

Comment 4

6 years ago
Will do. Andrew, thanks for the patch!
(Reporter)

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/5cac792f745e

Thanks again!
Assignee: nobody → andrew.quartey
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.