Closed Bug 704013 Opened 8 years ago Closed 8 years ago

nsStyleLinkElement::ParseLinkTypes should check for HTML5 white space

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: Ms2ger, Assigned: drexler)

Details

(Whiteboard: [good_first_bug][mentor=Ms2ger])

Attachments

(1 file)

See <http://www.whatwg.org/html/#space-character> / nsContentUtils::IsHTMLWhitespace.
Whiteboard: [good_first_bug][mentor=Ms2ger]
Changed checks for whitespace by IsAsciiSpace to IsHTMLWhitespace.
Attachment #575932 - Flags: review?(Ms2ger)
Comment on attachment 575932 [details] [diff] [review]
Check for HTML5 whitespace

LGTM, but I can't actually review this. Boris?
Attachment #575932 - Flags: review?(bzbarsky)
Attachment #575932 - Flags: review?(Ms2ger)
Attachment #575932 - Flags: feedback+
Comment on attachment 575932 [details] [diff] [review]
Check for HTML5 whitespace

The commit message should be closer to:

  Bug 704013.  nsStyleLinkElement::ParseLinkTypes should use HTML5 definition of "whitespace".

r=me with that adjusted.  Thanks for the patch!

Ms2ger, I trust you'll get this landed?
Attachment #575932 - Flags: review?(bzbarsky) → review+
Will do. Andrew, thanks for the patch!
https://hg.mozilla.org/mozilla-central/rev/5cac792f745e

Thanks again!
Assignee: nobody → andrew.quartey
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.