Last Comment Bug 704013 - nsStyleLinkElement::ParseLinkTypes should check for HTML5 white space
: nsStyleLinkElement::ParseLinkTypes should check for HTML5 white space
Status: RESOLVED FIXED
[good_first_bug][mentor=Ms2ger]
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: Andrew Quartey [:drexler]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-20 13:50 PST by :Ms2ger (⌚ UTC+1/+2)
Modified: 2011-12-04 14:08 PST (History)
2 users (show)
Ms2ger: in‑testsuite?
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Check for HTML5 whitespace (1.10 KB, patch)
2011-11-21 11:57 PST, Andrew Quartey [:drexler]
bzbarsky: review+
Ms2ger: feedback+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2011-11-20 13:50:02 PST
See <http://www.whatwg.org/html/#space-character> / nsContentUtils::IsHTMLWhitespace.
Comment 1 Andrew Quartey [:drexler] 2011-11-21 11:57:23 PST
Created attachment 575932 [details] [diff] [review]
Check for HTML5 whitespace

Changed checks for whitespace by IsAsciiSpace to IsHTMLWhitespace.
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2011-11-21 13:35:22 PST
Comment on attachment 575932 [details] [diff] [review]
Check for HTML5 whitespace

LGTM, but I can't actually review this. Boris?
Comment 3 Boris Zbarsky [:bz] 2011-11-28 18:48:21 PST
Comment on attachment 575932 [details] [diff] [review]
Check for HTML5 whitespace

The commit message should be closer to:

  Bug 704013.  nsStyleLinkElement::ParseLinkTypes should use HTML5 definition of "whitespace".

r=me with that adjusted.  Thanks for the patch!

Ms2ger, I trust you'll get this landed?
Comment 4 :Ms2ger (⌚ UTC+1/+2) 2011-11-28 23:51:49 PST
Will do. Andrew, thanks for the patch!
Comment 5 :Ms2ger (⌚ UTC+1/+2) 2011-12-04 14:08:09 PST
https://hg.mozilla.org/mozilla-central/rev/5cac792f745e

Thanks again!

Note You need to log in before you can comment on or make changes to this bug.