don't show transition animation when returning from awesome bar

VERIFIED FIXED

Status

()

Firefox for Android
General
VERIFIED FIXED
6 years ago
2 years ago

People

(Reporter: blassey, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 575802 [details] [diff] [review]
patch

we don't show an animation when opening the awesomebar, so showing it when closing the awesomebar feels wrong.
Attachment #575802 - Flags: review?(doug.turner)

Comment 1

6 years ago
Comment on attachment 575802 [details] [diff] [review]
patch

Review of attachment 575802 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe we should have an animation when opening?
Attachment #575802 - Flags: review?(doug.turner) → review+
(In reply to Doug Turner (:dougt) from comment #1)
> Maybe we should have an animation when opening?
I don't think so, the awesome screen is supposed to look like a drop down menu, the side swiping animation doesn't fit at all IMO
^ Madhava
pushed https://hg.mozilla.org/projects/birch/rev/2b1a44adaaef

Also, changed the summary to reflect that this only fixes the situation where you select a page from the awesome screen. Clicking back to dismiss the awesome screen will have to be fixed in a separate bug
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Summary: don't show transition animation when closing awesome bar → don't show transition animation when returning from awesome bar
Verified fixed on:
Fennec Nightly 13.0a1 (2012-02-09)
Device: Samsung Galaxy SII (Android 2.3.4)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.