704082 - Debugger / DebugCLI support for float/float4

Status: RESOLVED FIXED

(Tamarin Graveyard :: Virtual Machine, defect, P3)

Description

[Lars T Hansen]

We know we need such support.  We don't know what's involved, or quite how to test it.

Comment 1

[Lars T Hansen]

As far as DebugCLI is concerned, DebugCLI::ease2Atom deals briefly with atom types and could probably use a case for float, but ease2atom is not actually called from anywhere in DebugCLI and is defined as private, so the easier fix might be to just remove it.

Comment 2

[Lars T Hansen]

For the Debugger abstract interface, it looks like we might want to add a couple of methods, autoVarAsFloat and autoVarAsFloat4, to complement the others there.

I'm not sure the DebugStackFrame logic is right for values that can be more than sizeof(Atom) - that needs careful investigation.  It might be right because it operates on Atom arrays and uses MethodInfo functionality to convert natives to atoms, and thus does not embed that knowledge locally, but definitely needs to be checked.

Comment 3

[Lars T Hansen]

We have very scant test cases for the debugger.  We have the DebugCLI, but that tests only a subset of what's on offer.

Comment 4

[Lars T Hansen]

changeset:   7080:270aeeb5b58d
tag:         tip
user:        Lars T Hansen <[e-mail]>
date:        Wed Dec 14 15:57:13 2011 +0100
summary:     Fix 704082 - Debugger / DebugCLI support for float/float4