704192 - [traceback] Exception: NameError: global name 'smart_str' is not defined

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Matt Brandt [:mbrandt]]

Traceback (most recent call last):

 File "/data/www/mozillians-dev.allizom.org/mozillians/vendor/src/django/django/core/handlers/base.py", line 89, in get_response
   response = middleware_method(request)

 File "/data/www/mozillians-dev.allizom.org/mozillians/vendor/src/funfactory/funfactory/middleware.py", line 37, in process_request
   return HttpResponsePermanentRedirect(urlparams(new_path, **query))

 File "/data/www/mozillians-dev.allizom.org/mozillians/vendor/src/funfactory/funfactory/helpers.py", line 51, in urlparams
   if v is not None])

 File "/data/www/mozillians-dev.allizom.org/mozillians/vendor/src/funfactory/funfactory/helpers.py", line 61, in _urlencode
   return urllib.urlencode([(k, smart_str(v)) for k, v in items])

NameError: global name 'smart_str' is not defined

Comment 1

[[github robot]]

Commits pushed to https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/b07642a56ad9c593e997456b1856b7ade3abbac2
added multidb; updated funfactory; fix bug 704192

https://github.com/mozilla/mozillians/commit/d07557b72817ee7f9a4ab365b96ffefd4eca49ac
Merge pull request #62 from ednapiranha/bug704192

added multidb; updated funfactory; fix bug 704192

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

I can still reproduce the 500, on mozillians-dev; reopening for further investigation.

Comment 3

[Jen Fong-Adwent [:ednapiranha]]

Works for me now - are you still getting the errors?

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Jen Fong-Adwent [:ednapiranha] from comment #3)
> Works for me now - are you still getting the errors?

Nah; I think it was fixed in https://github.com/mozilla/mozillians/commit/ac4f6fc81481127c2462ae87972fdeded96cb2c0, https://github.com/mozilla/mozillians/commit/5fe339a2b40f9c6b8ef8ae3d0d442c4565dcab6a, and https://github.com/mozilla/mozillians/commit/222a3870c06cccdfba767ede8bb281d720c4038a.

Comment 5

[Matt Brandt [:mbrandt]]

Bumping to worksforme per comment 3 and comment 4.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Matt Brandt [:mbrandt] from comment #5)
> Bumping to worksforme per comment 3 and comment 4.

Should be Resolved FIXED, since there are commits.

-> FIXED.

Comment 7

[Matt Brandt [:mbrandt]]

Boom ... thx stephend. Nudging to verified fixed :)