704230 - Use nsXREAppData instead of extracting then reading in data

Status: RESOLVED DUPLICATE of bug 686466

(Core Graveyard :: Widget: Android, defect)

Description

[Doug Turner (:dougt)]

Attachment: use nsXREAppData.

Comment 1

[Doug Turner (:dougt)]

Attachment: temp workaround

temp workaround. Instead of doing this, we should reach into the APK and extract the file's content.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 575923 [details] [diff] [review]
temp workaround

Review of attachment 575923 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the bug filed and comment adjusted

::: toolkit/mozapps/update/nsUpdateService.js
@@ +695,5 @@
>    if (!localeFile.exists())
>      localeFile = FileUtils.getFile(KEY_GRED, [FILE_UPDATE_LOCALE]);
>  
> +  if (!localeFile.exists()) {
> +    // XXX temp workaround.  see bug 704230

file the bug that will fix this and put that in this comment

Comment 3

[Doug Turner (:dougt)]

https://hg.mozilla.org/mozilla-central/rev/a499cb7e3af1
https://hg.mozilla.org/mozilla-central/rev/8e8543323a93


Work around followup is bug 704238

Comment 4

[Mike Hommey [:glandium]]

... this is the same as bug 686466, which landed on m-i, and is thus going to conflict severely. I think we should backout these from m-c, because bug 686466 does the same thing accross the board.

Comment 5

[Ed Morley [:emorley]]

Backed out by request in #developers, due to comment 4:
https://hg.mozilla.org/mozilla-central/rev/243515ec2ad3