704332 - BrowserID popup is being blocked by Firefox

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://addons-dev.allizom.org/en-US/firefox/
2. Click Login/Register

expected behavior:
BrowserID popup opens

actual behavior:
BrowserID popup is blocked by Firefox

screencast: http://screencast.com/t/MadMFhlM0

I have seen this happen on apps-preview-dev as well, so i am making this a blocker for 690899

Comment 1

[krupa raj[:krupa]]

Error: b is null
Source File: https://browserid.org/include.js?_=1321919917885
Line: 37


Error: uncaught exception: [Exception... "Cannot modify properties of a WrappedNative"  nsresult: "0x80570034 (NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN)"  location: "JS frame :: chrome://global/content/bindings/autocomplete.xml :: onxblpopuphiding :: line 864"  data: no]

Comment 2

[krupa raj[:krupa]]

I filed https://github.com/mozilla/browserid/issues/628

Comment 3

[Gregory Koberger (:gkoberger)]

I was trying to be creative by loading BrowserID on the fly, but that won't work. Fixed!

https://github.com/mozilla/zamboni/commit/0a10cfb56491bca9ff151ffd8fa8213e1d5cddec

Krupa claims it sometimes randomly happened before my changes, but for now we'll close it.

Comment 4

[krupa raj[:krupa]]

I cannot reproduce this issue anymore.