A new 1.5 series should be version-bumped and released to pypi for the fix in bug 658509 .
Created attachment 576081 [details] [diff] [review] version bump to 1.5.7 bumps mozmill and mozrunner versions. jsbridge should not have been changed
Attachment #576081 - Flags: review?(ctalbert)
Assignee: nobody → jhammel
Status: NEW → ASSIGNED
Summary: bump versions for hotfix-1.5 and release to pypi → bump versions for hotfix-1.5 and release Mozmill 1.5.7 to pypi
Comment on attachment 576081 [details] [diff] [review] version bump to 1.5.7 thanks!
Attachment #576081 - Flags: review?(ctalbert) → review+
Actually, this won't work :( We do need to bump the jsbridge version because for some reason it depends on mozrunner ("historical reasons"). Since the mozrunner version is bumped, even though it is bumped correctly in jsbridge, you cannot bump it on pypi jsbridge this way. 2.0 ftw
Hm why not? There is no jsbridge package on pypi which is for Mozmill 2 and above. Or is the mozrunner package the problem?
The problem is that mozmill depends on jsbridge and mozrunner and jsbridge depends on mozrunner. This is the piece I had forgotten about (it shouldn't, but that's another story) and that breaks this plan. If we bump the mozmill and mozrunner versions and push them to pypi, mozmill will install the existing jsbridge and the new mozrunner. However, because we peg our versions, jsbridge will want the old mozrunner. setuptools will be unable to satisfy dependencies and bad things will happen (i.e. a broken installation).
Oh, so it only needs a version bump of jsbridge too? Means a simple update of the patch?
Created attachment 576521 [details] [diff] [review] version bump to 1.5.7 bumps all versions
(In reply to Henrik Skupin (:whimboo) from comment #6) > Oh, so it only needs a version bump of jsbridge too? Means a simple update > of the patch? That is correct, reflected in attachment 576521 [details] [diff] [review]
Comment on attachment 576521 [details] [diff] [review] version bump to 1.5.7 Looks good. Thanks for the clarification Jeff. Lets get it landed and Mozmill 1.5.7 released.
Attachment #576521 - Flags: review?(hskupin) → review+
pushed to hotfix-1.5: https://github.com/mozautomation/mozmill/commit/ba4dc0b004a2eb7aa17a1e8d2c338b19697187a6
pushed to pypi; easy_install mozmill in a blank virtualenv works
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Looks good. Thanks Jeff!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.