704401 - Staging/preproduction purge_builds.py should clobber rel-* directories after X amount of time

Status: RESOLVED DUPLICATE of bug 861733

(Release Engineering :: Release Automation: Other, defect, P4)

Description

[Rail Aliiev [:rail]]

Staging/preproduction purge_builds.py should clobber rel-* directories after X amount of time to allow slaves with low disk space clobber enough space.

Comment 1

[Rail Aliiev [:rail]]

Attachment: Use config file

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 576082 [details] [diff] [review]
Use config file

Rail, while I like this general approach (config file) I'm not sure I like:
|Override command line parameters with ones from config file| it just feels counter intuitive to me, if we pass in a list of ignore dirs, why are we overriding?

Also I think we need/want to print some message if we truely do want to override so we can know why, for example, a production machine might be misconfigured with purge_builds and is actually purging stuff we specified as excluded.

Comment 3

[Rail Aliiev [:rail]]

(In reply to Justin Wood (:Callek) from comment #2)
> Comment on attachment 576082 [details] [diff] [review] [diff] [details] [review]
> Use config file
> 
> Rail, while I like this general approach (config file) I'm not sure I like:
> |Override command line parameters with ones from config file| it just feels
> counter intuitive to me, if we pass in a list of ignore dirs, why are we
> overriding?

I totally agree with you here. The approach is not ideal. I was afraid that introducing another localconfig.py  variable would be a pain. Let's try to go this way.

Comment 4

[Rail Aliiev [:rail]]

Not working on this bug actively. Back to the pool.

Comment 5

[[e-mail] (:bhearsum)]

I think this happened in bug 861733...