Closed Bug 704405 Opened 13 years ago Closed 11 years ago

Topcrashers controller code should replace near duplicate, but incorrect model method.

Categories

(Socorro :: General, task)

Product:
Socorro
Component:
General
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: lonnen, Unassigned)

Details

Fetching the data for TCBS is handled but a big chunk of code in the topcrasher controller (near line 180), that is nearly but not identical to the method getTopCrashersViaWebService in the model.

The controller code is a little more recent and configurable, having been maintained to produce the expected TCBS. The model code is used in the general products controller.

Replace the model code with the controller code, then delete the now duplicate controller code. Audit and possibly update the products controller behavior.
Component: Socorro → General
Product: Webtools → Socorro
moot now that php has gone away.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.