704439 - PDF files are saved over existing ones for every new session

Status: VERIFIED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Cristian Nicolae (:xti)]

Attachment: Google News - actual result sample

Mozilla/5.0 (Android;Linux armv7l;rv:11.0a1)Gecko/20111121
Firefox/11.0a1 Fennec/11.0a1
Devices: Samsung Galaxy Nexus S
OS: Android 2.3.4

Steps to reproduce:
1. Open Fennec App
2. Browse to news.google.com
3. Tap on device Menu button > Save as PDF
4. Close Fennec
5. Repeat steps 1-3
6. Open the PDF file saved at step 5

Expected result:
The PDF file saved after step 5, has a different name than the PDF file saved at step 3 (Google News.pdf and Google News-1.pdf should be saved in (local)/download).
After step 6, no issue occurs while opening the PDF file.

Actual result:
The PDF file at step 5 is saved over the PDF file saved at step 3.
After step 6, the saved PDF file cannot be opened (please see the attached file).

Comment 1

[:Margaret Leibovic]

How are you closing fennec in step 4?

I think what's happening is that the download isn't actually finished by the time you close fennec in step 4, and if it was cancelled, that would make it appear that the second download paved over the first. Also, if the second download isn't finished by the time you try to open the PDF in step 6, you would have problems opening it.

The patch in bug 701797 will actually fix progress notifications so you'll know when the download is finished, but maybe in the mean time you could just try inserting more time in your STR between steps 3 and 4/6 and see if the problem still happens. (I've also found if you try to save a really small page as a PDF, like google.com, it downloads very quickly.)

Comment 2

[Cristian Nicolae (:xti)]

(In reply to Margaret Leibovic [:margaret] from comment #1)
> How are you closing fennec in step 4?
> 

I tap on device Menu button > More > Quit. Also the PDF file is saved before quitting Fennec.

Comment 3

[Doug Turner (:dougt)]

what is the status here?  Does this bug still occur?

Comment 4

[:Margaret Leibovic]

(In reply to Cristian Nicolae (:xti) from comment #2)
> (In reply to Margaret Leibovic [:margaret] from comment #1)
> > How are you closing fennec in step 4?
> > 
> 
> I tap on device Menu button > More > Quit. Also the PDF file is saved before
> quitting Fennec.

Did you verify that the PDF was saved by opening it from your downloads folder before quitting? I just want to make sure that we're really overwriting files here. (Also, now there's a progress notification that will let you know if the saving is actually done or not.)

Comment 5

[Cristian Nicolae (:xti)]

(In reply to Margaret Leibovic [:margaret] from comment #4)
> (In reply to Cristian Nicolae (:xti) from comment #2)
> > (In reply to Margaret Leibovic [:margaret] from comment #1)
> > > How are you closing fennec in step 4?
> > > 
> > 
> > I tap on device Menu button > More > Quit. Also the PDF file is saved before
> > quitting Fennec.
> 
> Did you verify that the PDF was saved by opening it from your downloads
> folder before quitting? I just want to make sure that we're really
> overwriting files here. (Also, now there's a progress notification that will
> let you know if the saving is actually done or not.)

I've verified it as you said above. If after step 3, the PDF file was for example ~200Kb and it was readable, after step 6, its size was ~400Kb and the PDF file was corrupted. I've checked this by going to download directory using a 3rd party app (like File Manager).
Also, I was able to reproduce this bug only if after step 3, the Complete Download notification was triggered.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Cristian / Margaret - Is this still happening? Is this what's suppose to happen?

Comment 7

[:Margaret Leibovic]

I just tried to reproduce, and I got two separate PDF files (Google News.pdf and Google News-1.pdf). I also tried quitting really quickly before the download finished, and in that case no PDF was produced, but I think that's expected. I think we can close this bug as WORKSFORME.

Cristian, please reopen if this is still a problem.

Comment 8

[Cristian Nicolae (:xti)]

Indeed, this issue doesn't occur anymore.
I've noticed that still there are issues about renaming the PDF files and saving another PDF file while the first one download is not completed.