Last Comment Bug 704593 - Remove JS-specific nsGlobalWindow::ClearTimeoutOrInterval()
: Remove JS-specific nsGlobalWindow::ClearTimeoutOrInterval()
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-22 12:49 PST by :Ms2ger (⌚ UTC+1/+2)
Modified: 2011-11-26 07:39 PST (History)
1 user (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (4.35 KB, patch)
2011-11-22 12:49 PST, :Ms2ger (⌚ UTC+1/+2)
jst: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2011-11-22 12:49:46 PST
Created attachment 576232 [details] [diff] [review]
Patch v1

Both the optionality and the handling for undefined are handled perfectly by the existing <= 0 check. (Both cases are converted to zero by the ToInt32 we do in XPConnect.)

 dom/base/nsGlobalWindow.cpp            |  78 +++++++++++++++++-------------------------------------------------------------
 dom/base/nsGlobalWindow.h              |   1 -
 dom/interfaces/base/nsIDOMJSWindow.idl |   4 ++--
 3 files changed, 19 insertions(+), 64 deletions(-)
Comment 1 Johnny Stenback (:jst, jst@mozilla.com) 2011-11-23 19:33:19 PST
Comment on attachment 576232 [details] [diff] [review]
Patch v1

Looks good!
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2011-11-26 07:39:19 PST
https://hg.mozilla.org/mozilla-central/rev/b882be166807

Note You need to log in before you can comment on or make changes to this bug.