Remove JS-specific nsGlobalWindow::ClearTimeoutOrInterval()

RESOLVED FIXED in mozilla11

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla11
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 576232 [details] [diff] [review]
Patch v1

Both the optionality and the handling for undefined are handled perfectly by the existing <= 0 check. (Both cases are converted to zero by the ToInt32 we do in XPConnect.)

 dom/base/nsGlobalWindow.cpp            |  78 +++++++++++++++++-------------------------------------------------------------
 dom/base/nsGlobalWindow.h              |   1 -
 dom/interfaces/base/nsIDOMJSWindow.idl |   4 ++--
 3 files changed, 19 insertions(+), 64 deletions(-)
Attachment #576232 - Flags: review?(jst)
Comment on attachment 576232 [details] [diff] [review]
Patch v1

Looks good!
Attachment #576232 - Flags: review?(jst) → review+
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/mozilla-central/rev/b882be166807
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.