Apps are not shown in app tab when launched from Dashboard with latest extension from develop branch

VERIFIED FIXED

Status

Web Apps
Extension
--
major
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: Mohamed Dabbagh, Assigned: mixedpuppy)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
With the latest extension built from the develop branch, clicking on apps in the Dashboard opens an app tab but the app is not shown. I tried with an extension built previously to the latest commit (6b34ccec35) and apps launch properly. It can be found here http://people.mozilla.com/~dclarke/openwebapps/Extension/older/openwebapps-cec6847099-11_18_2011.xpi. 

Steps to reproduce:
1. Launch Firefox
2. Install the apps extension built from the develop branch - Can be found http://people.mozilla.com/~dclarke/openwebapps/Extension and look for openwebapps-6b34ccec35-11_21_2011.xpi
3. Go to apps.mozillalabs.com/appdir and install an app
4. Go to myapps.mozillalabs.com and click on the app in the Dashboard

Actual Results:
An app tab is opened but nothing is shown. 

Expected Results:
The app tab is opened and the app is shown within it.
(Assignee)

Comment 1

7 years ago
This breakage is caused by the change in this commit/line

https://github.com/mozilla/openwebapps/commit/cce9aff02941601215ea0e64897b3861aa3a2a68#L2L135

As such, app.lauch_url is no longer available.  Since that was a computed value based on app.origin + app.lauch_path, several area's throughout the code are affected.

fix coming.
Assignee: nobody → mixedpuppy
(Assignee)

Comment 2

7 years ago
Created attachment 576576 [details] [diff] [review]
launch_path.patch
Attachment #576576 - Flags: review?
(Assignee)

Updated

7 years ago
Attachment #576576 - Flags: review? → review?(anant)
(Assignee)

Comment 3

7 years ago
Created attachment 576585 [details] [diff] [review]
launch_path.patch #2
Attachment #576576 - Attachment is obsolete: true
Attachment #576576 - Flags: review?(anant)
Attachment #576585 - Flags: review?(anant)
Comment on attachment 576585 [details] [diff] [review]
launch_path.patch #2

Looks good!
Attachment #576585 - Flags: review?(anant) → review+
(Assignee)

Comment 5

7 years ago
fixed https://github.com/mozilla/openwebapps/commit/b7ae544f4c2299e234982a2a99d0d215a8a40612
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

7 years ago
Tested with an extension built with the commit id corresponding to the fix. The extension build can be found here http://people.mozilla.com/~dclarke/openwebapps/Extension/ and look for openwebapps-5f90c92fd4-11_23_2011.xpi. Installed multiple apps from apps.mozillalabs.com/appdir and from https://apps-preview.mozilla.org/en-US/apps/ and they all launched properly. However, there is another case that I've found. If you already have apps installed with the extension that did not launch apps properly, even if you installed the new extension with the fix, the app still does not launch properly. So it's only newly installed apps with the working extension that will launch properly.

Here are steps to reproduce:
1. Launch Firefox
2. Install the extension found here: http://people.mozilla.com/~dclarke/openwebapps/Extension/older/openwebapps-10a4a41b66-11_22_2011.xpi
3. Go to apps.mozillalabs.com/appdir and install an app
4. Go to myapps.mozillalabs.com and try to launch the app, notice app is not shown within the app tab
5. Install the new extension with the fix: Can be found at http://people.mozilla.com/~dclarke/openwebapps/Extension/ and look for openwebapps-5f90c92fd4-11_23_2011.xpi
6. Go to myapps.mozillalabs.com and launch the app that you installed with the previously non-working extension - Notice it still does not launch properly even after a page refresh or after restarting Firefox

Re-opening for further comments/action.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 7

7 years ago
After speaking to Shane about this on IRC, it is deemed unnecessary to fix something that is a bug in our own builds. From now on, the latest extension will work as expected and so it's not needed to look into this further. Resolving as fixed again and will verify as fixed.
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 8

7 years ago
As per my comments #6 and #7, this is tested and works as expected. Verifying fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.